Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4210795ybi; Tue, 11 Jun 2019 02:52:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAnsM4jjUO047Hn6jRHLxaPB6lmAfyfCOdUPfwEAchBR4hp2RzwfN0R54d9teK0USSIu+m X-Received: by 2002:a63:18e:: with SMTP id 136mr19433117pgb.277.1560246730257; Tue, 11 Jun 2019 02:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560246730; cv=none; d=google.com; s=arc-20160816; b=DmN6S2mvNYk88Xh+Ojn66nYre9+1HajIlduYvetNv2MgVVYboNfgxI2PQJNQEy8ff6 ZvaBjBsrP7f5GfjYon+ccNRhgmLkzqr0iK8otZZbYsbdYiSuZ22F5DWkigVEmuk/HnLv RxMaC/uZkUTaCQlggj1tiauAuoPwfxYLnCAzL9Ez7eqUbt4Umo3K3zWWHMH0s/dRb3JS NYA3HKGd0w+f1mUZmjGBntetn+7UMNpJki/+tgR3CvCmdNSNn6upj3Tzdg1zuSWZDaqi TP+OVYNs/2tN9aQ/GCATQHJVODVZjJLfhBMidts3nBQC/mk5dfNkABwrd5wbVkpRhPyi s7ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=C6Llr/rAsG4UKg33V3rVQkWpWHeBxZaWA6nqxdk1nuE=; b=VN6TKMLmIjIXtVgJMQKLR2V0XlowOHMydAtLEgByBhE8T0U0aMexc/z8/PbCgocsr1 Oahx7pLgsDg0BWsi40iah0n9BxvxtUrwvECUjIlKImWlWL/PYNYboE6zJfiStHcWGF5p qrYtrMZ2heXbQFSFitFM2TfdmI7IkfasiG03aEcADcUebLmjMeTQpvxmb5K7HKk36Dta 2U18UpDqongGLSDbGzSfCgZBGt8dqg7IpEKydy2BbN6TvOo7ep/cLipx9ihTEFH7x1bJ JP4mr3QG1OXzoQMxJn4t2KKs3ZNFMFflbkGuzQI8oOcAucJCby7kl97wSMHQfRvmTks/ sX0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l3si12991810pgl.560.2019.06.11.02.51.53; Tue, 11 Jun 2019 02:52:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404960AbfFKJiZ (ORCPT + 99 others); Tue, 11 Jun 2019 05:38:25 -0400 Received: from foss.arm.com ([217.140.110.172]:56312 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404137AbfFKJiX (ORCPT ); Tue, 11 Jun 2019 05:38:23 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 200D0346; Tue, 11 Jun 2019 02:38:23 -0700 (PDT) Received: from e112298-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 80E7F3F73C; Tue, 11 Jun 2019 02:38:21 -0700 (PDT) From: Julien Thierry To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, marc.zyngier@arm.com, yuzenghui@huawei.com, wanghaibin.wang@huawei.com, james.morse@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, mark.rutland@arm.com, liwei391@huawei.com, Julien Thierry Subject: [PATCH v4 1/8] arm64: Do not enable IRQs for ct_user_exit Date: Tue, 11 Jun 2019 10:38:06 +0100 Message-Id: <1560245893-46998-2-git-send-email-julien.thierry@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> References: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For el0_dbg and el0_error, DAIF bits get explicitly cleared before calling ct_user_exit. When context tracking is disabled, DAIF gets set (almost) immediately after. When context tracking is enabled, among the first things done is disabling IRQs. What is actually needed is: - PSR.D = 0 so the system can be debugged (should be already the case) - PSR.A = 0 so async error can be handled during context tracking Do not clear PSR.I in those two locations. Signed-off-by: Julien Thierry Reviewed-by: James Morse Cc:Catalin Marinas Cc: Will Deacon Cc: Mark Rutland Cc: Marc Zyngier --- arch/arm64/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S index cd0c7af..89ab6bd 100644 --- a/arch/arm64/kernel/entry.S +++ b/arch/arm64/kernel/entry.S @@ -870,7 +870,7 @@ el0_dbg: mov x1, x25 mov x2, sp bl do_debug_exception - enable_daif + enable_da_f ct_user_exit b ret_to_user el0_inv: @@ -922,7 +922,7 @@ el0_error_naked: enable_dbg mov x0, sp bl do_serror - enable_daif + enable_da_f ct_user_exit b ret_to_user ENDPROC(el0_error) -- 1.9.1