Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932093AbVKURVi (ORCPT ); Mon, 21 Nov 2005 12:21:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932388AbVKURVi (ORCPT ); Mon, 21 Nov 2005 12:21:38 -0500 Received: from graphe.net ([209.204.138.32]:5077 "EHLO graphe.net") by vger.kernel.org with ESMTP id S932093AbVKURVh (ORCPT ); Mon, 21 Nov 2005 12:21:37 -0500 Date: Mon, 21 Nov 2005 09:21:32 -0800 (PST) From: Christoph Lameter X-X-Sender: christoph@graphe.net To: Pekka J Enberg cc: akpm@osdl.org, linux-kernel@vger.kernel.org, manfred@colorfullife.com Subject: Re: [PATCH] slab: minor cleanup to kmem_cache_alloc_node In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Score: -5.8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 16 On Mon, 21 Nov 2005, Pekka J Enberg wrote: > This patch gets rid of one if-else statement by moving current node allocation > check at the beginning of kmem_cache_alloc_node(). The problem with this is that the numa_node may change if irqs are still active and your patch moves the check for the numa node outside of the section where irqs are enabled. You could move the check for -1 into the section where interrupts are disabled. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/