Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4354020ybi; Tue, 11 Jun 2019 05:24:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxboJCTGlPRWJE1EBSevrmoOrF2olRIzc6pAy5VZoDVb4rhbhrfc2QRokNzfE4vSTfCU+4v X-Received: by 2002:a62:ee04:: with SMTP id e4mr76869843pfi.232.1560255844312; Tue, 11 Jun 2019 05:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560255844; cv=none; d=google.com; s=arc-20160816; b=gXGloNzqXE3FhfjGktSR71fgz9/Iaft3HAGR82XmsOQ3SQDHPPY9uNFfctOmRFQR6w gWU6Ex7gLIlzoF82kEl6/GuyCPsI/Dsd0ju+RppZPp//nctcByLncbLol4uwy3i05jvC wTdLONPQitFfR8aOjDbptiWUOaN7LWbc+1tzqLMQ1GYG2bUdNC/KANhd07Wc0681cdz9 ed1KdbGgtyftC8Eq8Bji/qAQ0vxV4+qvgo0ZmLU7nsGqKVd9Arbjm1UlUsMt85Sz87Gb y63a33Na36bN47+2kE2seFAmmy3AdTGmShxotg3biSqr3SJENReywiter2BW3nJD8c2E 1IpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=em9a5c0yFqdrvuzqwVxuFXpJaUhgDuicKQGVbe7tel8=; b=w6TaTlryVwAoHY+9Txxd1/D8QvsDkltkAGQrqmle5+ZyOuJmTAVaSuZ94cSnCzBY7G 2hQll3QE4UEjXObiNUaB7juG7E841XMRtQ+FOl8FSTuXFwQRaCXS6IF46HdhHIJrEJxY 7ayzUs0e/Jy8l0KaoYOBhOOWejtvDSJgUXIocbcb/QG195KoyzLrtsBpyI3dFvPOxVs9 TmiLyTIn8qZcwaqeMy57o2uzXVJBt8HA62ea7KkO0UQB2jObE9mY/kmgwognu1kdp51R 3DLboD3tHsZlqfrr60UhVpR+beKr3emNDwdH/FxKtgNYlY7mf6qOtciFVTDLB20oMLMV GZRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=DugH0Pe9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a26si12900400pfn.147.2019.06.11.05.23.49; Tue, 11 Jun 2019 05:24:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=DugH0Pe9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403800AbfFKLkM (ORCPT + 99 others); Tue, 11 Jun 2019 07:40:12 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43858 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389839AbfFKLkL (ORCPT ); Tue, 11 Jun 2019 07:40:11 -0400 Received: by mail-wr1-f67.google.com with SMTP id p13so2543918wru.10; Tue, 11 Jun 2019 04:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=em9a5c0yFqdrvuzqwVxuFXpJaUhgDuicKQGVbe7tel8=; b=DugH0Pe92Syj0dN+qGmocNpPu5t9g0BYj4ZgBJ5LE6Areja2C6ibXfq/kBIw2b+U6x oFg6QerSf6+HmwGnu+hG2lwIIk5g+pci9TJTqVSLDmyYZF1gyHyjuo0QKeoap1SU4HTr iCOq7HxcGvTwy4JO1TBqPE+9P9k2lRPk2tZtl5nyAFbdHPN8wdOOTxslYqShrL7wkSLx KPm1R29V9PbSLZU9GA/fcvjGXkXCuv9woM+rpWkt6oxIBrb+FOo1YSJ2rfYkP6ZRpg7C G/+alOgcCfK4a5p6gurtqa+YlYbW/qS5AJ9vR19G6BbMNRaRwcJUIJuJ/jAlq9Yje24n kv5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=em9a5c0yFqdrvuzqwVxuFXpJaUhgDuicKQGVbe7tel8=; b=cUHultPWoo3PTsfDH5drfobyO9XLAjBMzo4iNlAHF6kY4pU37zAoKTQbk0Obmo1LPn kFLr4RrSz8bz1eZbGBidi+OJ7fOfGYbrYBfSaBaNdkOlPQFkDRzwWlKOeKeJQPz/0jMy RRwxvhtl/v0uS9k9EvGjt2J1JkuLeUhvMhEGYaY1oGcqArScFMCAkjfmaGn+gck9MiKO H+zKdXo3VjE4Iu6jzRhMCN3+ZgMK6AwScxSvwjvWD/7yhdiA+E+BHZvnYN7vIgOA41Dw NuZm0o+o6IXVnw5Mmq116m/BKzH9m09qVUfhvC8A29+9PFG+UaTIYy7W/RMA0JryYdNR IXWw== X-Gm-Message-State: APjAAAUN/X+JZBUY8QqZlL7m66w+DHFsHpXQOlqVI6u/TfxDuEquAdVL ZNAb6Dwz03H9+TDKAUkNygc= X-Received: by 2002:a5d:4489:: with SMTP id j9mr4277436wrq.15.1560253208905; Tue, 11 Jun 2019 04:40:08 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:8cc3:8abd:4519:2cd6? ([2001:b07:6468:f312:8cc3:8abd:4519:2cd6]) by smtp.googlemail.com with ESMTPSA id d10sm20916346wrh.91.2019.06.11.04.40.07 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 04:40:08 -0700 (PDT) Subject: Re: [PATCH v2 2/3] KVM: LAPIC: lapic timer interrupt is injected by posted interrupt To: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1559799086-13912-1-git-send-email-wanpengli@tencent.com> <1559799086-13912-3-git-send-email-wanpengli@tencent.com> From: Paolo Bonzini Openpgp: preference=signencrypt Autocrypt: addr=pbonzini@redhat.com; keydata= mQHhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAbQj UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT6JAg0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSS5AQ0EVEJxcwEIAK+nUrsUz3aP2aBjIrX3a1+C+39R nctpNIPcJjFJ/8WafRiwcEuLjbvJ/4kyM6K7pWUIQftl1P8Woxwb5nqL7zEFHh5I+hKS3haO 5pgco//V0tWBGMKinjqntpd4U4Dl299dMBZ4rRbPvmI8rr63sCENxTnHhTECyHdGFpqSzWzy 97rH68uqMpxbUeggVwYkYihZNd8xt1+lf7GWYNEO/QV8ar/qbRPG6PEfiPPHQd/sldGYavmd //o6TQLSJsvJyJDt7KxulnNT8Q2X/OdEuVQsRT5glLaSAeVAABcLAEnNgmCIGkX7TnQF8a6w gHGrZIR9ZCoKvDxAr7RP6mPeS9sAEQEAAYkDEgQYAQIACQUCVEJxcwIbAgEpCRB+FRAMzTZp scBdIAQZAQIABgUCVEJxcwAKCRC/+9JfeMeug/SlCACl7QjRnwHo/VzENWD9G2VpUOd9eRnS DZGQmPo6Mp3Wy8vL7snGFBfRseT9BevXBSkxvtOnUUV2YbyLmolAODqUGzUI8ViF339poOYN i6Ffek0E19IMQ5+CilqJJ2d5ZvRfaq70LA/Ly9jmIwwX4auvXrWl99/2wCkqnWZI+PAepkcX JRD4KY2fsvRi64/aoQmcxTiyyR7q3/52Sqd4EdMfj0niYJV0Xb9nt8G57Dp9v3Ox5JeWZKXS krFqy1qyEIypIrqcMbtXM7LSmiQ8aJRM4ZHYbvgjChJKR4PsKNQZQlMWGUJO4nVFSkrixc9R Z49uIqQK3b3ENB1QkcdMg9cxsB0Onih8zR+Wp1uDZXnz1ekto+EivLQLqvTjCCwLxxJafwKI bqhQ+hGR9jF34EFur5eWt9jJGloEPVv0GgQflQaE+rRGe+3f5ZDgRe5Y/EJVNhBhKcafcbP8 MzmLRh3UDnYDwaeguYmxuSlMdjFL96YfhRBXs8tUw6SO9jtCgBvoOIBDCxxAJjShY4KIvEpK b2hSNr8KxzelKKlSXMtB1bbHbQxiQcerAipYiChUHq1raFc3V0eOyCXK205rLtknJHhM5pfG 6taABGAMvJgm/MrVILIxvBuERj1FRgcgoXtiBmLEJSb7akcrRlqe3MoPTntSTNvNzAJmfWhd SvP0G1WDLolqvX0OtKMppI91AWVu72f1kolJg43wbaKpRJg1GMkKEI3H+jrrlTBrNl/8e20m TElPRDKzPiowmXeZqFSS1A6Azv0TJoo9as+lWF+P4zCXt40+Zhh5hdHO38EV7vFAVG3iuay6 7ToF8Uy7tgc3mdH98WQSmHcn/H5PFYk3xTP3KHB7b0FZPdFPQXBZb9+tJeZBi9gMqcjMch+Y R8dmTcQRQX14bm5nXlBF7VpSOPZMR392LY7wzAvRdhz7aeIUkdO7VelaspFk2nT7wOj1Y6uL nRxQlLkBDQRUQnHuAQgAx4dxXO6/Zun0eVYOnr5GRl76+2UrAAemVv9Yfn2PbDIbxXqLff7o yVJIkw4WdhQIIvvtu5zH24iYjmdfbg8iWpP7NqxUQRUZJEWbx2CRwkMHtOmzQiQ2tSLjKh/c HeyFH68xjeLcinR7jXMrHQK+UCEw6jqi1oeZzGvfmxarUmS0uRuffAb589AJW50kkQK9VD/9 QC2FJISSUDnRC0PawGSZDXhmvITJMdD4TjYrePYhSY4uuIV02v028TVAaYbIhxvDY0hUQE4r 8ZbGRLn52bEzaIPgl1p/adKfeOUeMReg/CkyzQpmyB1TSk8lDMxQzCYHXAzwnGi8WU9iuE1P 0wARAQABiQHzBBgBAgAJBQJUQnHuAhsMAAoJEH4VEAzNNmmxp1EOoJy0uZggJm7gZKeJ7iUp eX4eqUtqelUw6gU2daz2hE/jsxsTbC/w5piHmk1H1VWDKEM4bQBTuiJ0bfo55SWsUNN+c9hh IX+Y8LEe22izK3w7mRpvGcg+/ZRG4DEMHLP6JVsv5GMpoYwYOmHnplOzCXHvmdlW0i6SrMsB Dl9rw4AtIa6bRwWLim1lQ6EM3PWifPrWSUPrPcw4OLSwFk0CPqC4HYv/7ZnASVkR5EERFF3+ 6iaaVi5OgBd81F1TCvCX2BEyIDRZLJNvX3TOd5FEN+lIrl26xecz876SvcOb5SL5SKg9/rCB ufdPSjojkGFWGziHiFaYhbuI2E+NfWLJtd+ZvWAAV+O0d8vFFSvriy9enJ8kxJwhC0ECbSKF Y+W1eTIhMD3aeAKY90drozWEyHhENf4l/V+Ja5vOnW+gCDQkGt2Y1lJAPPSIqZKvHzGShdh8 DduC0U3xYkfbGAUvbxeepjgzp0uEnBXfPTy09JGpgWbg0w91GyfT/ujKaGd4vxG2Ei+MMNDm S1SMx7wu0evvQ5kT9NPzyq8R2GIhVSiAd2jioGuTjX6AZCFv3ToO53DliFMkVTecLptsXaes uUHgL9dKIfvpm+rNXRn9wAwGjk0X/A== Message-ID: Date: Tue, 11 Jun 2019 13:40:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <1559799086-13912-3-git-send-email-wanpengli@tencent.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/19 07:31, Wanpeng Li wrote: > +static inline bool can_posted_interrupt_inject_timer(struct kvm_vcpu *vcpu) > +{ > + return posted_interrupt_inject_timer_enabled(vcpu) && > + !vcpu_halt_in_guest(vcpu); > +} > + I agree with Radim, what you want here is just use kvm_hlt_in_guest. I'll post shortly a prerequisite patch to block APF artificial halt when kvm_hlt_in_guest is true. Paolo