Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4356555ybi; Tue, 11 Jun 2019 05:26:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxApmCuhebx805mDzejXAJgcwmZ31ucXY5ASI4Z2M+mwAY7UJ2WK1iX0zkXZX8jSeSiiBpE X-Received: by 2002:a17:902:1e9:: with SMTP id b96mr29191014plb.277.1560256006569; Tue, 11 Jun 2019 05:26:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560256006; cv=none; d=google.com; s=arc-20160816; b=PUsGncH5aSJnYTGGHBEV5p6CUboV6s4uCUCU7nE7rMdBU5mLsYZAGvnJ3l0tlg5mBn AP9D8NaDkDD3du8Q4MKKCrZ/0tvjq2iBChka35VC3Ue58rIfGvYZbboiwRKynk6MMcMi txMewmDUc+zN1Fa3Mkj+9qGEjsdK0qc+3nrsCxb+469R1k6O+qnoXuvES5unKGdaUpJe iE7vOorl3YgmELuR/kAQ4v7V+23CIgN8uKilv5ow7RC/DYXqsOcoyKM/5wNuNWoVHnC/ Oy9aP3PyiYVlP1dCyIXEiyUMp/T+RG36D5hsC4hCokBRD+O8oIvluilLqnHHn2u2Ws66 ismg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lZXirDOut9vTqPwIy2+NlkcxYvoX0FlWKfU61yeOlXc=; b=qJjaNRK+pHrFogU5NGnmulNBYyz9L7g1GPgt1qrIAKj0qs7t6oLP973FFNHfXarjPF aX6jBnLjWoHK/ZQlXSdU5EH/HBe7DKZlrx7fi4MF/vQQkti+YtY4oo9Ou4r/S+6klKtk iMQqzMOOixizapmEKN9NpRPmt3Oa/Fjc/FuNxmfS5sFhxWkz3AVtBynzT6QeB9HHCuhK u5RuExKC7T/9iZAmslGMvLse4uVZf98t7L4QQ81sru0y5WotIBB5QRHiozdMQ9a38tua n/oZsy0PXWU7p97Wg9QhY86BLAMCwpgDUja0T/Ip1IBsi2S4wUC43AyeEGl8NnUNF9CK NRyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YnbqCKr3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d7si4605838plj.74.2019.06.11.05.26.31; Tue, 11 Jun 2019 05:26:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YnbqCKr3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390050AbfFKMGJ (ORCPT + 99 others); Tue, 11 Jun 2019 08:06:09 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38750 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387538AbfFKMGJ (ORCPT ); Tue, 11 Jun 2019 08:06:09 -0400 Received: by mail-lj1-f195.google.com with SMTP id o13so11353678lji.5 for ; Tue, 11 Jun 2019 05:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lZXirDOut9vTqPwIy2+NlkcxYvoX0FlWKfU61yeOlXc=; b=YnbqCKr3jMbW1jUhQ7uQsXIvK/YeDj1P1hgI7tJ+yc2M760ar+rV2fnGcMxMFQx1wT FiO54DDsoHx/hhRaCgxZ2iqXcQKCL8fvsP8wrc4ZlWO47rqYOxJV6vilfqgBx9UaGc19 dusFW2VjVyYmmklpJOfiOsnPGkzLf8G4gxxQDFLdU2qryMV3Dp23bEQWkd06axjVSiXG ducOaewG12zHLktAQRNFRqdfSdzNduv62pfY/+nKDqAcU+Ks3v/7V+8z3F6IOcsKN0Kl +u7KB2SOYLU957Xzo3/dkqbsKM9+yCMXUHiGWah/opMPIJTsTSPnF4iDDTXkDov3Ulvu u+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lZXirDOut9vTqPwIy2+NlkcxYvoX0FlWKfU61yeOlXc=; b=XtAUbrq4IHJ649FJaP32mJ/PeNQvh9nQyyazf17R0ViEImmbLc47jwE+KfgRBZ4BBg rj+n895fCyrc0xe4K4JuKlwCifxNfsiVhEDZxOCuu4tUNp/DfaizyJ9sUOcbWbe7CYEh CpIS1pC9Ag6YoBfhVFK7YGEeHG6H6dxTLG9rAF+eD7bZqNfC6jTY0+KvqSG/aeGzapOn 7bGl9HeYz9yiZM4kinsDrmJ1JJsVuPT8esaw6DjmizAI5SGv6ZGKc2s78PXKj7zUNvfF eMGWtrKaYOZ+2p8tOXa06cNI8PnwMlPLUgiAnF6IxWNrB0UFMhw++sthmJyw0PjoM3f1 /RPg== X-Gm-Message-State: APjAAAW2BJzpvfPwGDqwpdEVz5wB/VhR7DDhvxCu+NZ34II2+URFFauH PTkL1ALWQ805S8sB75rS4PS7oGy35t7Hq0bzfbo= X-Received: by 2002:a2e:a318:: with SMTP id l24mr27777904lje.36.1560254767023; Tue, 11 Jun 2019 05:06:07 -0700 (PDT) MIME-Version: 1.0 References: <20190610175234.196844-1-dianders@chromium.org> In-Reply-To: From: Erico Nunes Date: Tue, 11 Jun 2019 14:05:55 +0200 Message-ID: Subject: Re: [PATCH] drm/bridge/synopsys: dw-hdmi: Fix unwedge crash when no pinctrl entries To: Sean Paul Cc: Douglas Anderson , Sean Paul , "open list:ARM/Rockchip SoC..." , Heiko Stuebner , David Airlie , Andrzej Hajda , Jonas Karlman , LKML , dri-devel , Sam Ravnborg , Neil Armstrong , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Thomas Gleixner , Laurent Pinchart , Daniel Vetter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 10, 2019 at 10:51 PM Sean Paul wrote: > > On Mon, Jun 10, 2019 at 1:52 PM Douglas Anderson wrote: > > > > In commit 50f9495efe30 ("drm/bridge/synopsys: dw-hdmi: Add "unwedge" > > for ddc bus") I stupidly used IS_ERR() to check for whether we have an > > "unwedge" pinctrl state even though on most flows through the driver > > the unwedge state will just be NULL. > > > > Fix it so that we consistently use NULL for no unwedge state. > > > > Fixes: 50f9495efe30 ("drm/bridge/synopsys: dw-hdmi: Add "unwedge" for ddc bus") > > Reported-by: Erico Nunes > > Signed-off-by: Douglas Anderson > > Thanks Erico for the report, and Doug for fixing this up quickly, I've applied > the patch to drm-misc-next It does fix the issue. Thank you for the quick fix. Erico