Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1559799086-13912-1-git-send-email-wanpengli@tencent.com>
 <1559799086-13912-3-git-send-email-wanpengli@tencent.com> <c5530947-d48d-e3da-3056-ed64f7fa9a9d@redhat.com>
In-Reply-To: <c5530947-d48d-e3da-3056-ed64f7fa9a9d@redhat.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Tue, 11 Jun 2019 20:18:53 +0800
Message-ID: <CANRm+CzgLov6AYDVLYOFvZvo+bLS9AA+3J_qSis6PK3f9_2utw@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] KVM: LAPIC: lapic timer interrupt is injected by
 posted interrupt
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 11 Jun 2019 at 19:40, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 06/06/19 07:31, Wanpeng Li wrote:
> > +static inline bool can_posted_interrupt_inject_timer(struct kvm_vcpu *vcpu)
> > +{
> > +     return posted_interrupt_inject_timer_enabled(vcpu) &&
> > +             !vcpu_halt_in_guest(vcpu);
> > +}
> > +
>
> I agree with Radim, what you want here is just use kvm_hlt_in_guest.

Do it in v3.

>
> I'll post shortly a prerequisite patch to block APF artificial halt when
> kvm_hlt_in_guest is true.

Thanks Paolo!

Regards,
Wanpeng Li