Message-ID: <43820E23.2060303@trash.net>
Date: Mon, 21 Nov 2005 19:12:51 +0100
From: Patrick McHardy <kaber@trash.net>
User-Agent: Debian Thunderbird 1.0.7 (X11/20051017)
MIME-Version: 1.0
To: Folkert van Heusden <folkert@vanheusden.com>
CC: linux-kernel@vger.kernel.org
Subject: Re: [2.6.14] bug in inet_connection_sock.c -> lowest port always
 skipped
References: <20051121180224.GY32512@vanheusden.com>
In-Reply-To: <20051121180224.GY32512@vanheusden.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 902
Lines: 21

Folkert van Heusden wrote:
> There seems to be a small bug in inet_connection_sock.c: the lowest port
> set using sysctl (taken from 'sysctl_local_port_range') is always
> skipped in the first iteration.
> In inet_csk_get_port one can find this:
>                 if (hashinfo->port_rover < low)
>                         rover = low;
>                 else
>                         rover = hashinfo->port_rover;
>                 do {
>                         rover++;
> As you can see the first statement is a ++ causing the first port to
> always be skipped.

This has already been fixed three weeks ago by Stephen Hemminger's port
randomization patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/