Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Jun 2019 15:13:59 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Waiman Long <longman@redhat.com>
Cc:     Ingo Molnar <mingo@redhat.com>, Will Deacon <will.deacon@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, Davidlohr Bueso <dave@stgolabs.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        huang ying <huang.ying.caritas@gmail.com>
Subject: Re: [PATCH v8 16/19] locking/rwsem: Guard against making count
 negative
Message-ID: <20190611131359.GH3402@hirez.programming.kicks-ass.net>
References: <20190520205918.22251-1-longman@redhat.com>
 <20190520205918.22251-17-longman@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190520205918.22251-17-longman@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 20, 2019 at 04:59:15PM -0400, Waiman Long wrote:
>  static struct rw_semaphore __sched *
> +rwsem_down_read_slowpath(struct rw_semaphore *sem, int state, long adjustment)
>  {
> +	long count;
>  	bool wake = false;
>  	struct rwsem_waiter waiter;
>  	DEFINE_WAKE_Q(wake_q);
>  
> +	if (unlikely(!adjustment)) {
> +		/*
> +		 * This shouldn't happen. If it does, there is probably
> +		 * something wrong in the system.
> +		 */
> +		WARN_ON_ONCE(1);

	if (WARN_ON_ONCE(!adjustment)) {

> +
> +		/*
> +		 * An adjustment of 0 means that there are too many readers
> +		 * holding or trying to acquire the lock. So disable
> +		 * optimistic spinning and go directly into the wait list.
> +		 */
> +		if (rwsem_test_oflags(sem, RWSEM_RD_NONSPINNABLE))
> +			rwsem_set_nonspinnable(sem);

ISTR rwsem_set_nonspinnable() already does that test, so no need to do
it again, right?

> +		goto queue;
> +	}
> +
>  	/*
>  	 * Save the current read-owner of rwsem, if available, and the
>  	 * reader nonspinnable bit.