Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4466813ybi; Tue, 11 Jun 2019 07:09:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqy8YyzkLYzpCc6vvUHl74P3wnSF+QeYLXxiLoTAmrkprkFZ3cnyhjchIzaOHtbU22s5pehg X-Received: by 2002:aa7:8dcc:: with SMTP id j12mr15043478pfr.137.1560262146707; Tue, 11 Jun 2019 07:09:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560262146; cv=none; d=google.com; s=arc-20160816; b=trG6QEAlSOXhzYM8mbPFxyxAps3nqo6XgQnxdeRUAeqRO96O4SBnnou7i5Son2oMka tXrpxalWLKkShmiGlsbKnN/eqftVlbxAW4ZXN3FGyK4hx0pSTXnG1pMRGCajMGcfugLc 2kutci3XDqjYatoeNxYOwmPUzYtHWZAEQxTy8XJkaZ1CxtEPmEn93JwrAjrTxLUU6Ahc S3BZgBXLutbtdGoen1SWtg4fWVmiCmRo/pb/9sMdr3mGRZKm50VTjHK8H7Rl9DaqcRBY As/DCKTuNWvXYtj81FAb5Dx71oGHNDvxAJArQe/QGpH4NMOYE7qCUqoMZIAlh1Vl1F6g ErXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IWz7rmxRuciLtbVGhKXAvWnIWoY/90SUiu16s3M1vAk=; b=gGjh40dXekrlVQIr+1BNGA1yhnXYpyhbJdulzxvJcnK9V6RxknQgV15aS1olXDkYXZ aPwHyHEIRKOohsh3oqhJockl6ilhmsWibNZpbmLKZ8mHvys3jhgkvNByiWaGixaHlyaz +Mf5PCoHNIRQlMSawRTriGEVBEcCx0Cloz2ygSC5uvAce/GYnKYycUbCSVfgENYcO5/6 OoSgEMGoIE4D4cR/y9I5mgKSd/GfXcxRPNS3BHFtNT6pXl6p2Y1aFJ5FwbcbZzByEVj3 8XIH7ykrav3ML3AYJXH9I8GGqvxHe8P6KY2+cqDxzKjyIQK4wtJvCleLFfnDA7WRlIRe JYYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MrxNbxyw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si12304413pgj.113.2019.06.11.07.08.50; Tue, 11 Jun 2019 07:09:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MrxNbxyw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390499AbfFKNwT (ORCPT + 99 others); Tue, 11 Jun 2019 09:52:19 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:35734 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728344AbfFKNwT (ORCPT ); Tue, 11 Jun 2019 09:52:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IWz7rmxRuciLtbVGhKXAvWnIWoY/90SUiu16s3M1vAk=; b=MrxNbxywR2iqrcOnj6vuLsTEy tWldvXIf6cyAQENNln9VVSR4c4dc4mq9iq0ZiBlYqT+NEXj/xa2UBqMPcPTLee2+C1rZtOmresAMd 9gGkT6gOur2Qc6RC+Oxa6POW7rdb4t5F07I3FrP1nk6PNjviQYoLtMO4pfbJnHjbndylgNxjBNurw AW8ZdUfhyZCpgV3/X7hjLOpVeYJql4oqa8e7bCRgEFkzPOA1gkLqJbkH4EBK9DX3TjF+x/y7s3Wq6 UklaPdSaF7ZwsqIR9r/B9v1l2jotkzYTvPMQ9ns3I4dTNnupm+/2zKFMW5t3SNRyWF4o8pIOBGPYF lu39j1wOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1hahC8-0003JG-TH; Tue, 11 Jun 2019 13:52:12 +0000 Date: Tue, 11 Jun 2019 06:52:12 -0700 From: Christoph Hellwig To: Pingfan Liu Cc: John Hubbard , Andrew Morton , linux-mm@kvack.org, Ira Weiny , Mike Rapoport , Dan Williams , Matthew Wilcox , "Aneesh Kumar K.V" , Keith Busch , Christoph Hellwig , LKML Subject: Re: [PATCHv3 1/2] mm/gup: fix omission of check on FOLL_LONGTERM in get_user_pages_fast() Message-ID: <20190611135212.GA4591@infradead.org> References: <1559725820-26138-1-git-send-email-kernelfans@gmail.com> <20190605144912.f0059d4bd13c563ddb37877e@linux-foundation.org> <2b0a65ec-4fb0-430e-3e6a-b713fb5bb28f@nvidia.com> <20190611122935.GA9919@dhcp-128-55.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611122935.GA9919@dhcp-128-55.nay.redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 08:29:35PM +0800, Pingfan Liu wrote: > Unable to get a NVME device to have a test. And when testing fio on the How would a nvme test help? FOLL_LONGTERM isn't used by any performance critical path to start with, so I don't see how this patch could be a problem.