Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Jun 2019 17:26:55 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Christoph Hellwig <hch@infradead.org>,
        Oded Gabbay <oded.gabbay@gmail.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 8/8] habanalabs: enable 64-bit DMA mask in POWER9
Message-ID: <20190611152655.GA3972@kroah.com>
References: <20190611092144.11194-1-oded.gabbay@gmail.com>
 <20190611095857.GB24058@kroah.com>
 <20190611151753.GA11404@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190611151753.GA11404@infradead.org>
User-Agent: Mutt/1.12.0 (2019-05-25)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 11, 2019 at 08:17:53AM -0700, Christoph Hellwig wrote:
> On Tue, Jun 11, 2019 at 11:58:57AM +0200, Greg KH wrote:
> > That feels like a big hack.  ppc doesn't have any "what arch am I
> > running on?" runtime call?  Did you ask on the ppc64 mailing list?  I'm
> > ok to take this for now, but odds are you need a better fix for this
> > sometime...
> 
> That isn't the worst part of it.  The whole idea of checking what I'm
> running to set a dma mask just doesn't make any sense at all.

Oded, I thought I asked if there was a dma call you should be making to
keep this type of check from being needed.  What happened to that?  As
Christoph points out, none of this should be needed, which is what I
thought I originally said :)

thanks,

greg k-h