Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Jun 2019 12:47:22 -0300
From:   Arnaldo Carvalho de Melo <acme@redhat.com>
To:     Song Liu <songliubraving@fb.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>,
        David Carrillo Cisneros <davidca@fb.com>,
        Milian Wolff <milian.wolff@kdab.com>,
        Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] perf script/intel-pt: set synth_opts.callchain for
 use_browser > 0
Message-ID: <20190611154722.GC13332@redhat.com>
References: <20190610234216.2849236-1-songliubraving@fb.com>
 <def87b9f-a4fa-37ff-722a-9f14b14b2c7b@intel.com>
 <F8963F4B-46FF-41D2-B261-6DD2EE898D93@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <F8963F4B-46FF-41D2-B261-6DD2EE898D93@fb.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Tue, Jun 11, 2019 at 07:18:09AM +0000, Song Liu escreveu:
> 
> 
> > On Jun 10, 2019, at 11:45 PM, Adrian Hunter <adrian.hunter@intel.com> wrote:
> > On 11/06/19 2:42 AM, Song Liu wrote:
> >> +++ b/tools/perf/util/intel-pt.c
> >> @@ -2588,7 +2588,7 @@ int intel_pt_process_auxtrace_info(union perf_event *event,
> >> 	} else {
> >> 		itrace_synth_opts__set_default(&pt->synth_opts,
> >> 				session->itrace_synth_opts->default_no_sample);
> >> -		if (use_browser != -1) {
> >> +		if (use_browser > 0) {

> > That code has changed recently.  Refer:

> > 	https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=26f19c2eb7e54
 
> Thanks for a better fix! I was using Arnaldo's perf/urgent branch, and missed
> this one. 

Your report shows this one should move to perf/urgent, will try to do
that after processing a large perf/core batch...

- Arnaldo