Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp4672972ybi; Tue, 11 Jun 2019 10:30:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqwv2/FDVhDSy6GzQX2VamratpG0BkTqWh5ms3B+qxoEn/ifM0CqgxAXNKQUj3cqU7jobTtU X-Received: by 2002:aa7:81d4:: with SMTP id c20mr23775504pfn.235.1560274200026; Tue, 11 Jun 2019 10:30:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560274200; cv=none; d=google.com; s=arc-20160816; b=wg0zAOcpvUqat5/GGNYnozUC2cKrRzH6N6tQMRSw3AUHjhcr/Xl/Xz1FYalb8OjMXg vxzX9YHsFoQjzzdwO/bzrsOLHeTHFMrA45Y/BezVXuaqe0Nd/LPIdvKl+diTKkyiOFwZ DWNVP5yX2HPTX2sMIKLKB7PkZCecyHB2vAm8mJwdKujR149M22Eh7o5cKy39k0tMCz9w KNSmSNk5Sd9w1ZMgkWfvhkkPDuYW/fTqjbkU093MqStGafLcmYWijLUUd8R/Bp/Kuazz xcU2hJUXC9FtCCVyFna2Vc77Z9tdJfRV1PFWYQU3Y1EueRCR9OHxZbJk0BibJfNvw2ix 8FNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JHsL/2yRGNcuM0XgJZbs2DYkjnFPBd4EyIzkvA+Etl4=; b=lqFRD5n9h1F9vUJs812WjaY9AGC6lW9uhG0t6LkgQnn3QiIRew3tq1zZyw1wdbXACW 4EodECLh9B5o1kx2tDUi8qlAnZk3mCKxg0hXDScpN0pU8ZK/KuN/RfVI50iajKtn7eh6 OWi7MyNR2b7oBwAVTIDVc9e4LHG0Y6uQZN/9fRTbXtL5Kn6zBFd8eUuG0pTzx+hTMmZN nwW7e9txgJ8TRa+J+UJC14xEFyPxHxgZ2n156hykb/95YFxACAQ1LtIHU9dpFaUKVqfI wbzLpAFLdbMPWeGkH9BYOADzjMzagiRSnk7sxbDLI23eut8k2aGXJKVnvK27JUf0ciGd WOJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=et0qxBvO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id gn16si11287251plb.179.2019.06.11.10.29.44; Tue, 11 Jun 2019 10:30:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=et0qxBvO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406058AbfFKR2g (ORCPT + 99 others); Tue, 11 Jun 2019 13:28:36 -0400 Received: from mail.skyhub.de ([5.9.137.197]:56302 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405786AbfFKR2g (ORCPT ); Tue, 11 Jun 2019 13:28:36 -0400 Received: from zn.tnic (p200300EC2F0A6800C91F6799EDF090E8.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:6800:c91f:6799:edf0:90e8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 16E6A1EC0467; Tue, 11 Jun 2019 19:28:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1560274115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JHsL/2yRGNcuM0XgJZbs2DYkjnFPBd4EyIzkvA+Etl4=; b=et0qxBvOaNc/WQ8z/JDCOwW8xWD3nv96heNnSEsEtSs4xw4YNXdeiF/K8q7pHsfZ65TRDQ vjO/hunutbIc6ZDYkepwTVe0PkQ0qfXBdVg8hVuCnwlVO0eqjrDokCthOojfbouF2Dz5z2 dw0RlbZ7LYeGyJj+2YO+BQEH62W6V9w= Date: Tue, 11 Jun 2019 19:28:30 +0200 From: Borislav Petkov To: Robert Richter Cc: Tony Luck , James Morse , Mauro Carvalho Chehab , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 02/21] EDAC: Fixes to use put_device() after device_add() errors Message-ID: <20190611172830.GI31772@zn.tnic> References: <20190529084344.28562-1-rrichter@marvell.com> <20190529084344.28562-3-rrichter@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190529084344.28562-3-rrichter@marvell.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 29, 2019 at 08:44:05AM +0000, Robert Richter wrote: > Always use put_device() after device_add() failed. > > Signed-off-by: Robert Richter > --- > drivers/edac/edac_mc_sysfs.c | 36 +++++++++++++++++++----------------- > 1 file changed, 19 insertions(+), 17 deletions(-) I already have a partial fix for that, you can send me the rest ontop: https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/commit/?h=for-next&id=f5d59da9663d115b9cf62cce75a33382c880b560 Thx. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.