Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 11 Jun 2019 11:27:10 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc:     davem@davemloft.net, Pablo Neira Ayuso <pablo@netfilter.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jiri Pirko <jiri@mellanox.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Antoine Tenart <antoine.tenart@bootlin.com>,
        thomas.petazzoni@bootlin.com,
        =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= <mirq-linux@rere.qmqm.pl>
Subject: Re: [PATCH net] net: ethtool: Allow matching on vlan CFI bit
Message-ID: <20190611112710.211e218b@cakuba.netronome.com>
In-Reply-To: <20190611155456.15360-1-maxime.chevallier@bootlin.com>
References: <20190611155456.15360-1-maxime.chevallier@bootlin.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 11 Jun 2019 17:54:56 +0200, Maxime Chevallier wrote:
> Using ethtool, users can specify a classification action matching on the
> full vlan tag, which includes the CFI bit.
>=20
> However, when converting the ethool_flow_spec to a flow_rule, we use
> dissector keys to represent the matching patterns.
>=20
> Since the vlan dissector key doesn't include the CFI bit, this
> information was silently discarded when translating the ethtool
> flow spec in to a flow_rule.
>=20
> This commit adds the CFI bit into the vlan dissector key, and allows
> propagating the information to the driver when parsing the ethtool flow
> spec.
>=20
> Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule stru=
cture translator")
> Reported-by: Micha=C5=82 Miros=C5=82aw <mirq-linux@rere.qmqm.pl>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> Hi all,
>=20
> Although this prevents information to be silently discarded when parsing
> an ethtool_flow_spec, this information doesn't seem to be used by any
> driver that converts an ethtool_flow_spec to a flow_rule, hence I'm not
> sure this is suitable for -net.
>=20
> Thanks,
>=20
> Maxime
>=20
>  include/net/flow_dissector.h | 1 +
>  net/core/ethtool.c           | 5 +++++
>  2 files changed, 6 insertions(+)
>=20
> diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
> index 7c5a8d9a8d2a..9d2e395c6568 100644
> --- a/include/net/flow_dissector.h
> +++ b/include/net/flow_dissector.h
> @@ -46,6 +46,7 @@ struct flow_dissector_key_tags {
> =20
>  struct flow_dissector_key_vlan {
>  	u16	vlan_id:12,
> +		vlan_cfi:1,
>  		vlan_priority:3;
>  	__be16	vlan_tpid;
>  };
> diff --git a/net/core/ethtool.c b/net/core/ethtool.c
> index d08b1e19ce9c..43df34c1ebe1 100644
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -3020,6 +3020,11 @@ ethtool_rx_flow_rule_create(const struct ethtool_r=
x_flow_spec_input *input)
>  			match->mask.vlan.vlan_id =3D
>  				ntohs(ext_m_spec->vlan_tci) & 0x0fff;
> =20
> +			match->key.vlan.vlan_cfi =3D
> +				!!(ntohs(ext_h_spec->vlan_tci) & 0x1000);
> +			match->mask.vlan.vlan_cfi =3D
> +				!!(ntohs(ext_m_spec->vlan_tci) & 0x1000);

nit: since you're only using the output as a boolean, you can apply the
     byteswap to the constant and have it performed at build time.
     Another option is be16_get_bits() from linux/bitfield.h.

>  			match->key.vlan.vlan_priority =3D
>  				(ntohs(ext_h_spec->vlan_tci) & 0xe000) >> 13;
>  			match->mask.vlan.vlan_priority =3D