Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5300385ybi; Tue, 11 Jun 2019 23:46:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqz7B8Yz4I//g6/oNkVHb+LWQtGz4PctHZJNrM8y9IZII9EeYsVKP2LrlqqNNf31Xk4Sipfg X-Received: by 2002:a62:1dd0:: with SMTP id d199mr32307396pfd.257.1560321991302; Tue, 11 Jun 2019 23:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560321991; cv=none; d=google.com; s=arc-20160816; b=Zcab1M+0NQ/B34v4mQ1d8+Okb6Bd0qOJmAU9HDGIo880yBjt+MR6QYJU6G2I+H7R6G DUn9Ga2ckvV0YmrFYabKWlel8f15IjuXqjth7GfXCiGeEdEJkqouFr5CM1446YCTW50q 0kaO7puEHr+tUAvlY15PvVXtiZ6zaRD2cErJpCXZAJHHu4RlxeUMzglFaqW9JQFBBnsM qlj8+53ZBc4hzwmR3vAeQeO8CCYkiVC1Ax/PUQIwcOsCHREz5fztO9EQJBVRFDx6cwmM YQz7i5Bpr1sK2dao/OOBkJYKbbGQUwp7E8M2bQ5nnfqgBlBL/jFOg+V3NOJivi/FJK/Y 4fFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=WRyJ12ri3uGR+ARwuS2am3+LDX/orlJWlXM0gjutX2k=; b=YfYSHBy5pzCcF6oQnMO4KcPFwkmpWoqATwTYaz3Y2h1n/4P9UERDiP/j7RJ5+wIHh/ Gycu6wVGDY7uEpw5T+lsuvhQg/Zsd6yrDEitCiGkNKWQS1DM0RTsOpbPzxNDVGhHPjeL aetmfVf6Rkv6ApppEOxRNeQGWU+rWpfXGeARx1IOPlUTtoja7NBTohCY6htTk9PF/SvR irKHuETpKR/MEJ+zZ0T4nxnVNjV7xL7LdpffrFmF8r2F6LfRt0mE10vsx702YX2BQ5uC EyvX/ktIFlcoXtdaTLR5Ryw8MLTEWGTTjm/Fazjvq31qSRyaIMQ7PqHgePGnFxsmrO7Y yeQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JtJC0h0A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j6si3676240pll.162.2019.06.11.23.46.16; Tue, 11 Jun 2019 23:46:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=JtJC0h0A; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407877AbfFKXHZ (ORCPT + 99 others); Tue, 11 Jun 2019 19:07:25 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33637 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390115AbfFKXHY (ORCPT ); Tue, 11 Jun 2019 19:07:24 -0400 Received: by mail-wm1-f65.google.com with SMTP id h19so2963780wme.0; Tue, 11 Jun 2019 16:07:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WRyJ12ri3uGR+ARwuS2am3+LDX/orlJWlXM0gjutX2k=; b=JtJC0h0AA4ERUGsoz10C4kqQZcNKWhhFtY9F4DOiM4zj4wFUWiTK1GED0/sKhk2W0K 9qkIzVZSfTvBldFm7fBMtmKt4oGuY5O9pQL+tMADz1jq7eTNIk8II9gRa8DP1qKgTJal VILaCmXVg+MN2HJeP8cYD2vSAKz3OWZ6UgKJhbAUhvJhsSQA3TUAMnCoaGM3+B81rnk+ b36axgp0QB24W+Mo3xNttgHMOZOBbbKLF6xBKC0Ok7WKffbOmA4ikxbql/q4Gl8xq1Za 8mfvF43fBte9x8r0PQhJpnE6++NynAqPnHPojiN5AQTMZcKjJx1oqHKoFlm4mzFrXm+l Bp9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WRyJ12ri3uGR+ARwuS2am3+LDX/orlJWlXM0gjutX2k=; b=CSAeXEo24f9W8mIjM0CxzS0FG7xfyObYArl8mB+Ait2NRn5PQBQwJW0AFCEPPfauEH 4q2sg7Qjtk8UX1zMMRpj3K6TMqvwbJRdli0A0NTuljM989LoRncnPOOZWijtP4cGNYZO 6OI76TOaM3/EAtRjLqpbuzIeQXVx118YhplzKIVD0bVsz636lGwCpJ5f1o7RUWe008bh Hjk8gl2A+srjR1gqd1qKLUTnINVSpD0hy6yjncsAjgTFaNM3d6ZyBGiWtAF+wKaZZHDF aD+qAu3tHERyjcfIvz0etEkv5HdL/5azUMRxJC6awOzwQVtLTsXgoVYD9UAgOUs1q8S5 eJ5Q== X-Gm-Message-State: APjAAAXEycghR7K+f32+8jJeeoNFyYnLSWoaKl/EQw1BUEnEq1LiKlNU vL1LASypApHnwY//7f7DbAs= X-Received: by 2002:a1c:238d:: with SMTP id j135mr19824880wmj.53.1560294443128; Tue, 11 Jun 2019 16:07:23 -0700 (PDT) Received: from [10.67.49.123] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id l4sm2574501wmh.18.2019.06.11.16.07.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jun 2019 16:07:22 -0700 (PDT) Subject: Re: [PATCH net-next 1/4] net: dsa: do not check orig_dev in vlan del To: Vivien Didelot , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , andrew@lunn.ch References: <20190611214747.22285-1-vivien.didelot@gmail.com> <20190611214747.22285-2-vivien.didelot@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <3d73efad-17ee-8ba7-5c1f-c35f6e95cade@gmail.com> Date: Tue, 11 Jun 2019 16:07:11 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190611214747.22285-2-vivien.didelot@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/11/19 2:47 PM, Vivien Didelot wrote: > The current DSA code handling switchdev objects does not recurse into > the lower devices thus is never called with an orig_dev member being > a bridge device, hence remove this useless check. > > At the same time, remove the comments about the callers, which is > unlikely to be updated if the code changes and thus confusing. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli -- Florian