Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1560255429-7105-1-git-send-email-wanpengli@tencent.com>
 <1560255429-7105-2-git-send-email-wanpengli@tencent.com> <20190611203919.GB7520@amt.cnet>
In-Reply-To: <20190611203919.GB7520@amt.cnet>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Wed, 12 Jun 2019 08:45:10 +0800
Message-ID: <CANRm+CxX4__=p8BJ_Dd6GbKrgEpQH733sN_FATYrD2jNRayXaA@mail.gmail.com>
Subject: Re: [PATCH v3 1/4] KVM: LAPIC: Make lapic timer unpinned when timer
 is injected by pi
To:     Marcelo Tosatti <mtosatti@redhat.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 12 Jun 2019 at 04:39, Marcelo Tosatti <mtosatti@redhat.com> wrote:
>
> On Tue, Jun 11, 2019 at 08:17:06PM +0800, Wanpeng Li wrote:
> > From: Wanpeng Li <wanpengli@tencent.com>
> >
> > Make lapic timer unpinned when timer is injected by posted-interrupt,
> > the emulated timer can be offload to the housekeeping cpus.
> >
> > The host admin should fine tuned, e.g. dedicated instances scenario
> > w/ nohz_full cover the pCPUs which vCPUs resident, several pCPUs
> > surplus for housekeeping, disable mwait/hlt/pause vmexits to occupy
> > the pCPUs, fortunately preemption timer is disabled after mwait is
> > exposed to guest which makes emulated timer offload can be possible.
>
> Li,
>
> Nice!
>
> I think you can drop the HRTIMER_MODE_ABS_PINNED and
> instead have
>
> void kvm_set_pending_timer(struct kvm_vcpu *vcpu)
> {
>         kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
>         kvm_vcpu_kick(vcpu);
> }
>
> As an alternative to commit 61abdbe0bcc2b32745ab4479cc550f4c1f518ee2
> (as a first patch in your series).
>
> This will make the logic simpler (and timer migration, for
> nonhousekeeping case, ensures timer is migrated).

Good point. :)

>
> Also, should make this work for non housekeeping case as well.
> (But that can be done later).

The timer fire may cause other vCPUs vmexits for non housekeeping
case(after migrating timers fail during vCPU is scheduled to run in a
different pCPU). Could you explain more?

Regards,
Wanpeng Li