Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5390864ybi; Wed, 12 Jun 2019 01:33:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwQHWLSJ/v/P+42AUeC8H7jBG3Zkfe3hKRoZB1Aa4WoNC3DegrfBL7bkbjSqE42u7RJzZ8X X-Received: by 2002:a63:649:: with SMTP id 70mr24423352pgg.445.1560328432482; Wed, 12 Jun 2019 01:33:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560328432; cv=none; d=google.com; s=arc-20160816; b=LIF5h5+x2/EIhuulKf9PSwh2E1+YVKVezK6AkAHWojdu/LVSb3U2SpblYREsdxAWqA M5LB4n2nmhF9z80gYxVf37ltRzozFuo4ayq09WFtvlkkwgBomh96aulDGoGJmWKqHzov PBCkADij5ojwvzhhQzgxWXG9vCRpfDghT3c+TLVGbV1eZprElFWkCEwEUhNF43i+5UVH RCqyZTTtZzdlAJuKBxbXRpBfgjM1F6zhh6horCDEKJpTmYnruHVnARW4I8oB3QbN6Xxw kcdeN+syi/ThzAVSIlyJwzkjWg6t/D0/+kb3nnjOqWwV0XFHD4cSJouZDcw3B8lz/7yM HhzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=19WvUo48XI/OSfGfc3UTqswjKFqP5DlY9/f6/2PmRkc=; b=x2QuHNpMwOTbatsG1KdJFCJD4mrXbh39TMlzPUCR61U5VXV6pNeZDbTn77zzTDD9So RTqI9Oa+z0rAQ+8f5A/ueb3vH37FgsrNOr33D7qdUgeWjoOFA1mf7zCm+eeSuBrIU5CJ 8hLsImICO69BzMBAuZB6m2lcYSSyCVPVz7+cPAR5WQygL4xwtqfv4mQW4Ue2tld8eCrp M0GDa5PbPko9SuBO3ljW/HN0L3SvDoWr1lUVYeU62pKUk2Hap6nPaJVbL4/pmbuwVOql q5cL6AyLZ/vNW0pE3NyN/+Kv2/eG/DGMUgbx6P1ehV9JWD2jZE5mssY4jXLxYRKoUBlu WUgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="gyOXmd/B"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1si477702plf.87.2019.06.12.01.33.37; Wed, 12 Jun 2019 01:33:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="gyOXmd/B"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408133AbfFLHPi (ORCPT + 99 others); Wed, 12 Jun 2019 03:15:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:53680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405874AbfFLHPi (ORCPT ); Wed, 12 Jun 2019 03:15:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B146205ED; Wed, 12 Jun 2019 07:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560323737; bh=Pgn4z8eXDtvYuB4h8Srt1Pl6cmZJ+jrdGbEb4/HW8F4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gyOXmd/Bk2MY+ObjQoit0TWOjS+A3rYkI8Ikbk1QNX/JbNILMih4G3ibdsrKy44JR 7ruaWDGVo8ybEPMU8WZhzsjFQSjflJ4nYRMnwH0bRWMfWVfNJbJKasKwZaLca/ZkSc gwOUUi5a8BqneqAbLIWnNU9FATVBUi5J1fmPsHFU= Date: Wed, 12 Jun 2019 09:15:34 +0200 From: Greg KH To: "zhangxiaoxu (A)" Cc: tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org, dvhart@infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] futex: Fix futex lock the wrong page Message-ID: <20190612071534.GA14367@kroah.com> References: <1560304465-68966-1-git-send-email-zhangxiaoxu5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 09:50:25AM +0800, zhangxiaoxu (A) wrote: > This patch is for stable branch linux-4.4-y. > > On 2019/6/12 9:54, ZhangXiaoxu wrote: > > The upstram commit 65d8fc777f6d ("futex: Remove requirement > > for lock_page() in get_futex_key()") use variable 'page' as > > the page head, when merge it to stable branch, the variable > > `page_head` is page head. > > > > In the stable branch, the variable `page` not means the page > > head, when lock the page head, we should lock 'page_head', > > rather than 'page'. > > > > It maybe lead a hung task problem. > > > > Signed-off-by: ZhangXiaoxu > > Cc: stable@vger.kernel.org > > --- > > kernel/futex.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) I do not understand. Please read https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to submit a patch to the stable trees properly. If the commit is not in Linus's tree, then we can not take it, unless something is _very_ broken and it is the only way it can be resolved. thanks, greg k-h