Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5391037ybi; Wed, 12 Jun 2019 01:34:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNNHn5188DsdjoEd9ToOcObyq1epLeoGFaV7VE32kQ4I9lPLsqAI7WtQUkThxLYmBasF21 X-Received: by 2002:a63:610d:: with SMTP id v13mr23813275pgb.341.1560328446674; Wed, 12 Jun 2019 01:34:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560328446; cv=none; d=google.com; s=arc-20160816; b=Cf/n6MYpK3jPuXG1DNyOWuO+mTn+luk2CdLmIIX3XWaaksMvT4S6YzMxlvBXaAOYfe T52veINcdpVD1ly0IDRspCBNWEhr1EdbSKTIVMFBB0G6+3P8Szn8QCsXj6u7/umYLsuk YgWwr6b8Qj9tOG7PoJ5rgJz3cQjGz3cpaUgzUGP0oAnAkYxEfajdC9Laun58VCeKGKWS wyjjkOxqB3NTPb9Gbl11kXpzqZPByfVaFwfsTdllzgJEe132SUP+Hk9rYDfr3yKYiu2v mtTfUrKlQHizb7X70+bShNTur9JiGbgK5GjVWR03pbfo8iRm4YMglBpmvFYrElqTkBgB Bd1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature; bh=0ODbO3O86IZbeyLTELnAsNdoPj20jfybxtEdmAdJekg=; b=cCspP2tedJfzutQhDm9gy9U+uGZyTbZHeQ0XrEDiwANKSExqvg8LhcruCiD3WcC1ub WHtvUKRtBIDMQZOKoKo5bKWLKa4fhYKTEr5uCbzVlySUQR3aRltmxkELz5sGC7Md6c4R 0cOa/RmnBKYUVy+Ur/syK/xo/qnS2wcpiSJ3jZNKYjWF0CjCebs94HwSkDrEZBij+S/q eBA8YvE15WQBr1aekvhntuAztq4u1Y5ZjmkmeF3t5wDVFaKcD2wXYZdKghR2UpT7SiSr JISYfEMykRy3PPgOU764qoDIv6G5G7I++GqjkwFb8L7oZJuh91mDSdpypnl32YnepwDE 9r5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=NZisbeET; dkim=pass header.i=@codeaurora.org header.s=default header.b=fH7UUeLK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 21si4315925pfo.138.2019.06.12.01.33.50; Wed, 12 Jun 2019 01:34:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=NZisbeET; dkim=pass header.i=@codeaurora.org header.s=default header.b=fH7UUeLK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408255AbfFLHQU (ORCPT + 99 others); Wed, 12 Jun 2019 03:16:20 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45788 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408237AbfFLHQT (ORCPT ); Wed, 12 Jun 2019 03:16:19 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id CC8A460CF0; Wed, 12 Jun 2019 07:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560323777; bh=ZDenoutQ8tySlfx7o5y40gHxnZ0cmOtx5yB5PYRMHmA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NZisbeETz/AZMzwGSdFOZiOqWp73WTqtMls5xf1tG3OnsdWaMNVzKbqqF0WkpbZGq 8uO6b2yHkhrWiGWu1F8lmBErv8oh5cDW0RTbIZgWvfc+oLTvjoIRhiW5utBJB2j4kR 4JmXodbHBy9J7gUBd9M5r1qfYUpLW2/anh/NH4hM= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-41.ap.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vivek.gautam@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 61FEC6079C; Wed, 12 Jun 2019 07:16:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1560323776; bh=ZDenoutQ8tySlfx7o5y40gHxnZ0cmOtx5yB5PYRMHmA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fH7UUeLK3+kqO83hVtXl56T1WIhkP6eW0JYYrlPUZNHgAbzESfLbM/tOtml7sS28d fwqixWo8P2YOm6GGkznTU6GxQ6ssmGc06woxSZVQmKtLfDsOMjFBTHakz+NJylbO+L XycWgtXwLI+Qzlpl3T/oXYBcIhuR+DmVb30baGx8= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 61FEC6079C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vivek.gautam@codeaurora.org From: Vivek Gautam To: agross@kernel.org, robh+dt@kernel.org, will.deacon@arm.com, robin.murphy@arm.com, joro@8bytes.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org, david.brown@linaro.org, Vivek Gautam Subject: [PATCH v3 2/4] firmware/qcom_scm: Add scm call to handle smmu errata Date: Wed, 12 Jun 2019 12:45:52 +0530 Message-Id: <20190612071554.13573-3-vivek.gautam@codeaurora.org> X-Mailer: git-send-email 2.16.1.72.g5be1f00a9a70 In-Reply-To: <20190612071554.13573-1-vivek.gautam@codeaurora.org> References: <20190612071554.13573-1-vivek.gautam@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Qcom's smmu-500 needs to toggle wait-for-safe logic to handle TLB invalidations. Few firmwares allow doing that through SCM interface. Add API to toggle wait for safe from firmware through a SCM call. Signed-off-by: Vivek Gautam Reviewed-by: Bjorn Andersson --- drivers/firmware/qcom_scm-32.c | 5 +++++ drivers/firmware/qcom_scm-64.c | 13 +++++++++++++ drivers/firmware/qcom_scm.c | 6 ++++++ drivers/firmware/qcom_scm.h | 5 +++++ include/linux/qcom_scm.h | 2 ++ 5 files changed, 31 insertions(+) diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c index 215061c581e1..bee8729525ec 100644 --- a/drivers/firmware/qcom_scm-32.c +++ b/drivers/firmware/qcom_scm-32.c @@ -614,3 +614,8 @@ int __qcom_scm_io_writel(struct device *dev, phys_addr_t addr, unsigned int val) return qcom_scm_call_atomic2(QCOM_SCM_SVC_IO, QCOM_SCM_IO_WRITE, addr, val); } + +int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, bool enable) +{ + return -ENODEV; +} diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c index b6dca32c5ac4..23de54b75cd7 100644 --- a/drivers/firmware/qcom_scm-64.c +++ b/drivers/firmware/qcom_scm-64.c @@ -550,3 +550,16 @@ int __qcom_scm_io_writel(struct device *dev, phys_addr_t addr, unsigned int val) return qcom_scm_call(dev, QCOM_SCM_SVC_IO, QCOM_SCM_IO_WRITE, &desc, &res); } + +int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, bool en) +{ + struct qcom_scm_desc desc = {0}; + struct arm_smccc_res res; + + desc.args[0] = QCOM_SCM_CONFIG_SAFE_EN_CLIENT_ALL; + desc.args[1] = en; + desc.arginfo = QCOM_SCM_ARGS(2); + + return qcom_scm_call_atomic(dev, QCOM_SCM_SVC_SMMU_PROGRAM, + QCOM_SCM_CONFIG_SAFE_EN, &desc, &res); +} diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 2ddc118dba1b..2b3b7a8c4270 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -344,6 +344,12 @@ int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) } EXPORT_SYMBOL(qcom_scm_iommu_secure_ptbl_init); +int qcom_scm_qsmmu500_wait_safe_toggle(bool en) +{ + return __qcom_scm_qsmmu500_wait_safe_toggle(__scm->dev, en); +} +EXPORT_SYMBOL(qcom_scm_qsmmu500_wait_safe_toggle); + int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val) { return __qcom_scm_io_readl(__scm->dev, addr, val); diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom_scm.h index 99506bd873c0..0b63ded89b41 100644 --- a/drivers/firmware/qcom_scm.h +++ b/drivers/firmware/qcom_scm.h @@ -91,10 +91,15 @@ extern int __qcom_scm_restore_sec_cfg(struct device *dev, u32 device_id, u32 spare); #define QCOM_SCM_IOMMU_SECURE_PTBL_SIZE 3 #define QCOM_SCM_IOMMU_SECURE_PTBL_INIT 4 +#define QCOM_SCM_SVC_SMMU_PROGRAM 0x15 +#define QCOM_SCM_CONFIG_SAFE_EN 0x3 +#define QCOM_SCM_CONFIG_SAFE_EN_CLIENT_ALL 0x2 extern int __qcom_scm_iommu_secure_ptbl_size(struct device *dev, u32 spare, size_t *size); extern int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr, u32 size, u32 spare); +extern int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, + bool enable); #define QCOM_MEM_PROT_ASSIGN_ID 0x16 extern int __qcom_scm_assign_mem(struct device *dev, phys_addr_t mem_region, size_t mem_sz, diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h index 3f12cc77fb58..aee3d8580d89 100644 --- a/include/linux/qcom_scm.h +++ b/include/linux/qcom_scm.h @@ -57,6 +57,7 @@ extern int qcom_scm_set_remote_state(u32 state, u32 id); extern int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare); extern int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size); extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare); +extern int qcom_scm_qsmmu500_wait_safe_toggle(bool en); extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val); extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val); #else @@ -96,6 +97,7 @@ qcom_scm_set_remote_state(u32 state,u32 id) { return -ENODEV; } static inline int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare) { return -ENODEV; } static inline int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size) { return -ENODEV; } static inline int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) { return -ENODEV; } +static inline int qcom_scm_qsmmu500_wait_safe_toggle(bool en) { return -ENODEV; } static inline int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val) { return -ENODEV; } static inline int qcom_scm_io_writel(phys_addr_t addr, unsigned int val) { return -ENODEV; } #endif -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation