Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5450160ybi; Wed, 12 Jun 2019 02:43:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqwsBDGsLQw0f10iHdxkhTN3BiG0l/cSZs3ea1dspEg0qVqK64cl8Asl1usG04R04ydWNe8r X-Received: by 2002:a62:5486:: with SMTP id i128mr85312720pfb.156.1560332587282; Wed, 12 Jun 2019 02:43:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560332587; cv=none; d=google.com; s=arc-20160816; b=I9317CXdSsGjfkyIfkNU80ukKCznWU/LvvvW9kOr8ZcUfS4iPUwMLGECTuNOXWMm7T DnWilmtLB0ZG0lL7lS35/sZ7ZOtE6YqvTFxTQvpKisBWlLexiBv+SJdmg53cHq9xzrGl o22NV0r07nji1vKf0qRJSrtjz1PYBPM96c2kdMgkIjoEgPF8royDm/lMIfAUjguN9R2x xLxFXLzNadwMX3j4Wf2ic73eqbnrkWkRwtWCS6JwTh4pViIwXSUz8L+3wGzT5yiEyqqR oIZLk/0iJD+R62i6/uMY+1QFfR/M2Gn0ga0Dfu7wG0UwpmTrIV67WXDKoBManY/njrMi 3beQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GbyCcP0P6CtvOUhdOB2kGSjXvxXCXy0VBA/B3vFhrYM=; b=JRxwhG4YZfPk5c6OG3WAtYSzWlAIFOjmx0648gvWyUT+nG/SWCAsHgOMdtkYqZzM6s FQr4sv9H//9oTFxLMVjYMtjXsyMX+9htPTYm2sL6mJ8LgUJNCcQLMT3u92d5aCByNzyW VinMaxEnb/VSjyob5L7DywFx4/eQDMUa1GRYAF+e5HUmEgxgr9Al9WSsmBid4rvJ+z/V 3Z1cBT4O+eGxPM4mQJ8losulf9fZQFj5hsnXDwynjkikMNlFp6hyCcOKQd5BNl9fMRgo 4NwZwl4JaTPWaFUzPYu1YwUSYNRWvaqMnrQHzJuZAgxVTp3u9ilAJEWiwpKNKuiq7aMI x2pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="v9c3s1/A"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f24si14927489pgi.289.2019.06.12.02.42.50; Wed, 12 Jun 2019 02:43:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="v9c3s1/A"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437658AbfFLJlg (ORCPT + 99 others); Wed, 12 Jun 2019 05:41:36 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:40273 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437298AbfFLJlf (ORCPT ); Wed, 12 Jun 2019 05:41:35 -0400 Received: by mail-wm1-f65.google.com with SMTP id v19so5783800wmj.5 for ; Wed, 12 Jun 2019 02:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GbyCcP0P6CtvOUhdOB2kGSjXvxXCXy0VBA/B3vFhrYM=; b=v9c3s1/Ac06DyH1iUKtg7MdnBEsehlR5I0sut5tbdZ8qlsFcfAmYKJU8KJQcu5o5Lb y42upQrN3qOS0CtmlPoFSNambsDTHhzG9C/L8/PHIKCMqTiLdEvEWcQx4diMP0k0uswh JKRA9sj9V1Vavijyu3+LKDhUFhhWqI4a9zV4VSKgsc8gqNt95OyZgrpV8Cvp5nCajLjK eS/6zB6jAo2ApKcWPq5YRF0LYXhGfdOzfRy8uly0VYPQ5Hw3XxHaFDaNhBTi31ucaJtf 5fGm3zRfxAJqZ2IFlRngUk+yQgB+RWOU7mk8scPoJfyPmV3GmXzYYsWCSGqVqWsRLKWE 3lPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GbyCcP0P6CtvOUhdOB2kGSjXvxXCXy0VBA/B3vFhrYM=; b=MM2GFvZeKapdp6gv0F+9NalzOvLnD9JMiejjvHhmb8LEs6GFMSSgv78BTrgEyNfJjy eekyw2ILyQtWcklAsKY9pwEalSrS5sHF/w+FAlwT8s9GY4Wkl4NECesM4n9+y+KEm5OT ajjDciySes+RioLUM2pSaABolBwKauAwXhknWtrm5gU0raliSfTx2RZCVzXtlqw5blkU c0f0QQ/jqQeLYQVH22DElyRuznrqIiF9UDV4pWfFEVX9drLvAtdRVnWOxLHrzErBbvgC 5cTgg2WTK/WwP5t6i+joa2plJtB1PlVn389Y8fZjAtSbPHyPQPyuJeHBa0hi7qTdW0V3 OeEA== X-Gm-Message-State: APjAAAVu+ug87J8PUKw+dlr7JJk/XIOxN63q7vcan5lxwFZNbhnX1H8B 9ZKt1/+xxBqoXcQjET2BYnwLimqLlJA= X-Received: by 2002:a1c:678a:: with SMTP id b132mr20709233wmc.17.1560332493322; Wed, 12 Jun 2019 02:41:33 -0700 (PDT) Received: from dell ([185.80.132.160]) by smtp.gmail.com with ESMTPSA id v67sm4493632wme.24.2019.06.12.02.41.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Jun 2019 02:41:32 -0700 (PDT) Date: Wed, 12 Jun 2019 10:41:31 +0100 From: Lee Jones To: Stefan Mavrodiev Cc: Heiko Stuebner , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] mfd: rk808: Check pm_power_off pointer Message-ID: <20190612094131.GG4797@dell> References: <20190607124226.17694-1-stefan@olimex.com> <20190607124226.17694-2-stefan@olimex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190607124226.17694-2-stefan@olimex.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Jun 2019, Stefan Mavrodiev wrote: > The function pointer pm_power_off may point to function from other > module (PSCI for example). If rk808 is removed, pm_power_off is > overwritten to NULL and the system cannot be powered off. > > This patch checks if pm_power_off points to a module function. > > Signed-off-by: Stefan Mavrodiev > --- > Changes is v3: > - Add explanation comments > Changes in v2: > - Initial release actually > > drivers/mfd/rk808.c | 17 +++++++++++------ > include/linux/mfd/rk808.h | 1 + > 2 files changed, 12 insertions(+), 6 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog