Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for
 LE and BR/EDR connections"
From:   Johan Hedberg <johan.hedberg@gmail.com>
In-Reply-To: <9ad95905975e09646f0f2aa967140881cbbe3477.camel@hadess.net>
Date:   Wed, 12 Jun 2019 13:04:57 +0300
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        "open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <77E07614-6F68-4661-BC6D-2BD610DBD62A@gmail.com>
References: <20190522052002.10411-1-anarsoul@gmail.com>
 <6BD1D3F7-E2F2-4B2D-9479-06E27049133C@holtmann.org>
 <7B7F362B-6C8B-4112-8772-FB6BC708ABF5@holtmann.org>
 <CA+E=qVfopSA90vG2Kkh+XzdYdNn=M-hJN_AptW=R+B5v3HB9eA@mail.gmail.com>
 <CA+E=qVdLOS9smt-nBxg9Lon0iTZr87kONSp-XPKj9tqB4bvnqw@mail.gmail.com>
 <723142BB-8217-4A01-A2B9-F527174FDC0F@holtmann.org>
 <20190612070701.GA13320@kroah.com>
 <9ad95905975e09646f0f2aa967140881cbbe3477.camel@hadess.net>
To:     Bastien Nocera <hadess@hadess.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 12 Jun 2019, at 12.38, Bastien Nocera <hadess@hadess.net> wrote:
>=20
> On Wed, 2019-06-12 at 09:07 +0200, Greg Kroah-Hartman wrote:
>> On Tue, Jun 11, 2019 at 11:36:26PM +0200, Marcel Holtmann wrote:
>>> Hi Vasily,
>>>=20
>>>> Can we get this revert merged into stable branches? Bluetooth HID
>>>> has
>>>> been broken for many devices for quite a while now and RFC patch
>>>> that
>>>> fixes the breakage hasn't seen any movement for almost a month.
>>>=20
>>> lets send the RFC patch upstream since it got enough feedback that
>>> it fixes the issue.
>>=20
>> According to Hans, the workaround did not work.
>=20
> Is it possible that those folks were running Fedora, and using a
> version of bluetoothd without a fix for using dbus-broker as the D-Bus
> daemon implementation?
>=20
> I backported the fix in an update last week:
> https://bugzilla.redhat.com/show_bug.cgi?id=3D1711594

I don=E2=80=99t know if that=E2=80=99s the case, but at least based on =
the comment here:

https://bugzilla.kernel.org/show_bug.cgi?id=3D203643#c10

it looks like there=E2=80=99s still a race with controllers that do =
support reading the encryption key size. The peer device may send an =
L2CAP Connect Request before we=E2=80=99ve completed reading the key =
size, in which case we=E2=80=99d still reject the request. For making =
this work again I=E2=80=99m not aware of any other quick solution than a =
revert.

Johan