Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5827752ybi; Wed, 12 Jun 2019 09:07:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqw1R7wuKeljvg06cW6fk5xoWBFAoMlN/9jupkVi4UnPT+ra1Hunnh/sQviw59MWG6/WVT72 X-Received: by 2002:a17:902:b695:: with SMTP id c21mr30345645pls.160.1560355678777; Wed, 12 Jun 2019 09:07:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560355678; cv=none; d=google.com; s=arc-20160816; b=Wp0/u0VzbdNwxoyMmPS9pOAIYE6jDF9BBcLU5wMMeyZt3SKHHAPNYgQ8y95hW7j5kt bNmJRmRVmiTR575xwrAlMh3xSe4Eil2jfvmKVc2SkFncJSxzdycQ1uL13HuSC1bvT9Tr OQCxvjGpyuHjtTU1poDck3wMynCQliOEandMkh2REVa4kI894H+oCsLjOzl+fRMj4wVj vkl6VZTJEdFc0R4CPi21kTfvkTzZ6p2C83wkuZsGgaUoy/6IQO+mV09iHJpoRY8Chon/ UIIr2gkFuPSRPhjndhYqTk06nj+nfQkyyAb/oe59sa+hbC+8QlBhj5qna3TP5ArzDdTI k++w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :from:references:cc:to:subject; bh=qZ5kdqBB2BRNApVcr6osqWfu4GA5FvHNpY6S2znuotk=; b=VaxEiWNh3wBijYBi0/E5KO2GHg5JUymj6jkZAUIkzV4XUd41S6RU0iHPIpQmJnpwxQ x7z6/bgdAWPd2f6LuGyDiDzLyWB1YatzKQ2454IMwftEUUf4eXaHlj8ZYgvYIYLe0rwl FWMMQufOwAfejbMz5JOzxzKqSuTfO4yt6xj5gVl/Xo1E3YwoGNhV+Wfy92vktA8FXifs sVbxBtGnuSEtajq+KWeW/8mgidqqT8BUv1MqoNTBd304Zc0QgneN/PJhwkNec6X4oLLT SsODz8lwi8S6Y0UNbYTFkhEXHdDxESZutIuWyGik/Xdrkzq40GRexCfceDqdc6uyYHUB gT/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7si192337pgd.155.2019.06.12.09.07.42; Wed, 12 Jun 2019 09:07:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408567AbfFLLH7 (ORCPT + 99 others); Wed, 12 Jun 2019 07:07:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57724 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2407551AbfFLLH7 (ORCPT ); Wed, 12 Jun 2019 07:07:59 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5CB2gBo089603 for ; Wed, 12 Jun 2019 07:07:57 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2t2ytx99aa-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 12 Jun 2019 07:07:57 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 12 Jun 2019 12:07:55 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 12 Jun 2019 12:07:53 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5CB7ps952166910 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 11:07:51 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6753B42041; Wed, 12 Jun 2019 11:07:51 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B1CA54203F; Wed, 12 Jun 2019 11:07:50 +0000 (GMT) Received: from [10.0.2.15] (unknown [9.145.62.239]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 12 Jun 2019 11:07:50 +0000 (GMT) Subject: Re: [PATCH v2 1/4] s390/pkey: Use -ENODEV instead of -EOPNOTSUPP To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-s390@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Cornelia Huck References: <20190612102248.18903-1-david@redhat.com> <20190612102248.18903-2-david@redhat.com> <7f313d87-f9ea-e291-49e2-8da29cf41680@linux.ibm.com> <53936c66-ca09-98a7-4c3c-eae8c6024887@redhat.com> From: Harald Freudenberger Date: Wed, 12 Jun 2019 13:07:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <53936c66-ca09-98a7-4c3c-eae8c6024887@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 19061211-0012-0000-0000-000003287567 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19061211-0013-0000-0000-000021617CC3 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-12_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120077 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.06.19 12:41, David Hildenbrand wrote: > On 12.06.19 12:39, Harald Freudenberger wrote: >> On 12.06.19 12:22, David Hildenbrand wrote: >>> systemd-modules-load.service automatically tries to load the pkey module >>> on systems that have MSA. >>> >>> Pkey also requires the MSA3 facility and a bunch of subfunctions. >>> Failing with -EOPNOTSUPP makes "systemd-modules-load.service" fail on >>> any system that does not have all needed subfunctions. For example, >>> when running under QEMU TCG (but also on systems where protected keys >>> are disabled via the HMC). >>> >>> Let's use -ENODEV, so systemd-modules-load.service properly ignores >>> failing to load the pkey module because of missing HW functionality. >>> >>> Reviewed-by: Cornelia Huck >>> Signed-off-by: David Hildenbrand >>> --- >>> drivers/s390/crypto/pkey_api.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/s390/crypto/pkey_api.c b/drivers/s390/crypto/pkey_api.c >>> index 45eb0c14b880..ddfcefb47284 100644 >>> --- a/drivers/s390/crypto/pkey_api.c >>> +++ b/drivers/s390/crypto/pkey_api.c >>> @@ -1695,15 +1695,15 @@ static int __init pkey_init(void) >>> * are able to work with protected keys. >>> */ >>> if (!cpacf_query(CPACF_PCKMO, &pckmo_functions)) >>> - return -EOPNOTSUPP; >>> + return -ENODEV; >>> >>> /* check for kmc instructions available */ >>> if (!cpacf_query(CPACF_KMC, &kmc_functions)) >>> - return -EOPNOTSUPP; >>> + return -ENODEV; >>> if (!cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_128) || >>> !cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_192) || >>> !cpacf_test_func(&kmc_functions, CPACF_KMC_PAES_256)) >>> - return -EOPNOTSUPP; >>> + return -ENODEV; >>> >>> pkey_debug_init(); >>> >> You missed one match in this file. Function pkey_clr2protkey() >> also does a cpacf_test_func() and may return -EOPNOTSUPP. >> I checked the call chain, it's save to change the returncode there also. > That's unrelated to module loading (if I am not wrong), shall we still > include this change here? > > Thanks! That would be nice. However, I agree it is not related to module loading. > >> If done, Thanks and add my >> reviewed-by: Harald Freudenberger >> >