Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Jun 2019 13:35:38 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Nadav Amit <namit@vmware.com>
Cc:     Julien Freche <jfreche@vmware.com>,
        Pv-drivers <Pv-drivers@vmware.com>,
        Arnd Bergmann <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vmw_ballon: no need to check return value of
 debugfs_create functions
Message-ID: <20190612113538.GA14793@kroah.com>
References: <20190611185528.GA4659@kroah.com>
 <5A5203EB-A789-4C48-9C25-EF0C0CBCE5CD@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5A5203EB-A789-4C48-9C25-EF0C0CBCE5CD@vmware.com>
User-Agent: Mutt/1.12.0 (2019-05-25)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 11, 2019 at 07:36:36PM +0000, Nadav Amit wrote:
> Please change the title of the patch to “vmw_balloon” (it is currently
> “vmw_ballon”).

Oops, will fix, sorry about that.

> > On Jun 11, 2019, at 11:55 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> > 
> > When calling debugfs functions, there is no need to ever check the
> > return value.  The function can work or not, but the code logic should
> > never do something different based on this.
> 
> I remember I saw a discussion about it, and didn’t know the resolution.
> 
> If that's the decision (assuming debugfs initialization always succeeds),
> and after fixing the title of the patch:
> 
>   Acked-by: Nadav Amit <namit@vmware.com>

Thanks for the review!

greg k-h