Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Jun 2019 08:48:24 -0300
From:   Mauro Carvalho Chehab <mchehab@infradead.org>
To:     Wolfram Sang <wsa@the-dreams.de>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ruslan Babayev <ruslan@babayev.com>,
        Andrew de Quincey <adq_dvb@lidskialf.net>
Subject: Re: linux-next: build warning after merge of the i2c tree
Message-ID: <20190612084824.16671efa@coco.lan>
In-Reply-To: <20190612110904.qhuoxyljgoo76yjj@ninjato>
References: <20190611102528.44ad5783@canb.auug.org.au>
        <20190612081929.GA1687@kunai>
        <20190612080226.45d2115a@coco.lan>
        <20190612110904.qhuoxyljgoo76yjj@ninjato>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Wed, 12 Jun 2019 13:09:04 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> Hi Mauro,
> 
> > That entire use of _P, _R and _ri looks weird into my eyes. The code there  
> 
> Yes.
> 
> > do things like:
> > 
> > #define _P 32
> > 
> > ...
> > 
> >         if (_P == 64)
> >                 reg1[1] |= 0x40;  
> 
> Yup, I saw this, too, but didn't feel like refactoring the driver.
> Thanks for stepping up!
> 
> > I'll work on a patch to address it.  
> 
> OK, so that means I should send my pull request after yours in the next
> merge window? To avoid the build breakage?

Either that or you can apply my patch on your tree before the
patch that caused the breakage. 

Just let me know what works best for you.

> 
> Kind regards,
> 
>    Wolfram
> 


Thanks,
Mauro