Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190606090612.16685-1-igor.opaniuk@gmail.com> <3b84f3cc6cd5399f25ebd8e1c8559c58@agner.ch>
In-Reply-To: <3b84f3cc6cd5399f25ebd8e1c8559c58@agner.ch>
From:   Igor Opaniuk <igor.opaniuk@gmail.com>
Date:   Wed, 12 Jun 2019 15:49:03 +0300
Message-ID: <CAByghJZJzFN9c9V-o=SV0z07++RPqsB0R8MTsovbtLr3vqJgyw@mail.gmail.com>
Subject: Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1
To:     Stefan Agner <stefan@agner.ch>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de,
        Fabio Estevam <festevam@gmail.com>, linux-imx@nxp.com,
        Marcel Ziswiler <marcel@ziswiler.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Stefan,

On Wed, Jun 12, 2019 at 3:17 PM Stefan Agner <stefan@agner.ch> wrote:
>
> On 06.06.2019 11:06, Igor Opaniuk wrote:
> > From: Igor Opaniuk <igor.opaniuk@toradex.com>
> >
> > Allows to use the SD interface at a higher speed mode if the card
> > supports it. For this the signaling voltage is switched from 3.3V to
> > 1.8V under the usdhc1's drivers control.
> >
> > Signed-off-by: Igor Opaniuk <igor.opaniuk@toradex.com>
> > ---
> >  arch/arm/boot/dts/imx6ul.dtsi                  |  4 ++++
> >  arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +++++++++--
> >  arch/arm/boot/dts/imx6ull-colibri.dtsi         |  6 ++++++
> >  3 files changed, 19 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.d=
tsi
> > index fc388b84bf22..91a0ced44e27 100644
> > --- a/arch/arm/boot/dts/imx6ul.dtsi
> > +++ b/arch/arm/boot/dts/imx6ul.dtsi
> > @@ -857,6 +857,8 @@
> >                                        <&clks IMX6UL_CLK_USDHC1>,
> >                                        <&clks IMX6UL_CLK_USDHC1>;
> >                               clock-names =3D "ipg", "ahb", "per";
> > +                             fsl,tuning-step=3D <2>;
> > +                             fsl,tuning-start-tap =3D <20>;
> >                               bus-width =3D <4>;
> >                               status =3D "disabled";
> >                       };
> > @@ -870,6 +872,8 @@
> >                                        <&clks IMX6UL_CLK_USDHC2>;
> >                               clock-names =3D "ipg", "ahb", "per";
> >                               bus-width =3D <4>;
> > +                             fsl,tuning-step=3D <2>;
> > +                             fsl,tuning-start-tap =3D <20>;
> >                               status =3D "disabled";
> >                       };
> >
> > diff --git a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > index 006690ea98c0..7dc7770cf52c 100644
> > --- a/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > +++ b/arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi
> > @@ -145,13 +145,20 @@
> >  };
> >
> >  &usdhc1 {
> > -     pinctrl-names =3D "default";
> > +     pinctrl-names =3D "default", "state_100mhz", "state_200mhz", "sle=
ep";
> >       pinctrl-0 =3D <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_cd>;
> > -     no-1-8-v;
> > +     pinctrl-1 =3D <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
> > +     pinctrl-2 =3D <&pinctrl_usdhc1_100mhz &pinctrl_snvs_usdhc1_cd>;
>
> Should that not be pinctrl_usdhc1_200mhz?
>

Correct, thanks for pointing this out.
Taking into account that the patch was already accepted by Shawn, will
send another to fix this typo ASAP (added to my todo list).

Thanks

> --
> Stefan
>
> > +     pinctrl-3 =3D <&pinctrl_usdhc1 &pinctrl_snvs_usdhc1_sleep_cd>;
> >       cd-gpios =3D <&gpio5 0 GPIO_ACTIVE_LOW>;
> >       disable-wp;
> >       wakeup-source;
> >       keep-power-in-suspend;
> >       vmmc-supply =3D <&reg_3v3>;
> > +     vqmmc-supply =3D <&reg_sd1_vmmc>;
> > +     sd-uhs-sdr12;
> > +     sd-uhs-sdr25;
> > +     sd-uhs-sdr50;
> > +     sd-uhs-sdr104;
> >       status =3D "okay";
> >  };
> > diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > index 9ad1da159768..d56728f03c35 100644
> > --- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > +++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> > @@ -545,6 +545,12 @@
> >               >;
> >       };
> >
> > +     pinctrl_snvs_usdhc1_sleep_cd: snvs-usdhc1-cd-grp-slp {
> > +             fsl,pins =3D <
> > +                     MX6ULL_PAD_SNVS_TAMPER0__GPIO5_IO00     0x0
> > +             >;
> > +     };
> > +
> >       pinctrl_snvs_wifi_pdn: snvs-wifi-pdn-grp {
> >               fsl,pins =3D <
> >                       MX6ULL_PAD_BOOT_MODE1__GPIO5_IO11       0x14


--=20
Best regards - Freundliche Gr=C3=BCsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk@gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk