Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5933424ybi; Wed, 12 Jun 2019 10:57:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxA81FqXzXvKQGsUY04T+f6oqTqq/VfSB2gsfu/LzKgr2CqPshw2MSpOk6uo+8umqBuCUg X-Received: by 2002:a17:90a:dc86:: with SMTP id j6mr378083pjv.141.1560362265505; Wed, 12 Jun 2019 10:57:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362265; cv=none; d=google.com; s=arc-20160816; b=QnIULaTlBurj3CrfxkUZvBQHy51euFNp32IpLNCsBooj8cmzYMgDG87VaXPjmcB3ag SD1zxsM+k4lncxYm3yd46EXeBb154Y3KSUKqV2DwKePxQnZ/gDxpYgBkjYyZqM/ncHxj ku/pD9gqia3SFwPFEc5W+uErz1uvoD7BXOJi64SC0F+9J7d9jpm6lHYOmTvNnPdLlURU wtTftjGBbBktYdrKf642sCSM4DMfMkFJjsEyaCoFhBHznVYfmNNhUa3kCBdbjVBzSqze BEVy9nVMEE8LI6qru6YSiZfdIZANr4BErkIy+hx+ttbw/cSPA/mfZb8ZZau0U98MKm1P u5sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uOZzvrbV13EstfeYyPfU+t6sLptsnQrEVHS01/XxS2A=; b=SF6V7Mh0P/FY+aw/kGBICt4lnjvTTkstGhk7WEJSg5F1DxSFMkxsPrMLp+dFXq/Q+l u5Gs+Cb91uGwIhd0AstqSAaPEizatm9vX5fPerILIrEw75f2dYSoO778O/XYGYJef+gx peEjfaM3kAFFV1GDYQWIhZq09t0HmaYeNCH6gFLI0Rl+zv05LV/US+Nmvyjjece0Xm6+ sShi8hzmcA9vMIQNJJzQELzKlxciHFxUbIgcofxicOVVIG/yXL5+XUuvr8UK7txdHsIp 7aI2iET75RbgdKtqt7wpHNDUnUgDgwVClynYdAgZSSwH1LH36imbR5ZRRFNiQ6BRinLP q1YQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s8si414624pfe.22.2019.06.12.10.57.31; Wed, 12 Jun 2019 10:57:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439382AbfFLNLp (ORCPT + 99 others); Wed, 12 Jun 2019 09:11:45 -0400 Received: from 8bytes.org ([81.169.241.247]:43616 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439360AbfFLNLp (ORCPT ); Wed, 12 Jun 2019 09:11:45 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 9C2EF64D; Wed, 12 Jun 2019 15:11:43 +0200 (CEST) Date: Wed, 12 Jun 2019 15:11:43 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Cc: "alex.williamson@redhat.com" , "jacob.jun.pan@linux.intel.com" , "eric.auger@redhat.com" , "ashok.raj@intel.com" , "yi.l.liu@intel.com" , "robdclark@gmail.com" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , Robin Murphy Subject: Re: [PATCH v2 0/4] iommu: Add device fault reporting API Message-ID: <20190612131143.GF21613@8bytes.org> References: <20190603145749.46347-1-jean-philippe.brucker@arm.com> <20190612081944.GB17505@8bytes.org> <0f21e1b2-837f-87ba-6cf3-f6490d9e2a57@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f21e1b2-837f-87ba-6cf3-f6490d9e2a57@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 12:54:51PM +0100, Jean-Philippe Brucker wrote: > Thanks! As discussed I think we need to add padding into the iommu_fault > structure before this reaches mainline, to make the UAPI easier to > extend in the future. It's already possible to extend but requires > introducing a new ABI version number and support two structures. Adding > some padding would only require introducing new flags. If there is no > objection I'll send a one-line patch bumping the structure size to 64 > bytes (currently 48) Sounds good, please submit the patch. Regards, Joerg