Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        Chris Spencer <christopher.spencer@sea.co.uk>,
        Horia Geanta <horia.geanta@nxp.com>
CC:     "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        Cory Tusar <cory.tusar@zii.aero>,
        Chris Healy <cphealy@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Iuliana Prodan <iuliana.prodan@nxp.com>
Subject: Re: [PATCH v2 1/4] crypto: caam - do not initialise clocks on the
 i.MX8
Thread-Topic: [PATCH v2 1/4] crypto: caam - do not initialise clocks on the
 i.MX8
Thread-Index: AQHVHWwJspoqZbZRu0O/kUXjAFynTw==
Date:   Wed, 12 Jun 2019 13:53:57 +0000
Message-ID: <VI1PR04MB50558864B434388A52A00915EEEC0@VI1PR04MB5055.eurprd04.prod.outlook.com>
References: <20190607200225.21419-1-andrew.smirnov@gmail.com>
 <20190607200225.21419-2-andrew.smirnov@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 47fdf32f-0069-4d44-15a2-08d6ef3d6a9b
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2019 13:53:57.8886
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: leonard.crestez@nxp.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5904
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07.06.2019 23:03, Andrey Smirnov wrote:=0A=
=0A=
> There are no clocks that the CAAM driver needs to initialise on the=0A=
> i.MX8.=0A=
=0A=
The clk handling inside CAAM is very convoluted and this patch doesn't =0A=
help. All the driver actually does is "enable all required clocks", this =
=0A=
shouldn't be complicated.=0A=
=0A=
I propose adding a const caam_soc_data struct which has a bool flag =0A=
marking if each clock is required or not, the replace all the =0A=
of_machine_is_compatible() logic with statements of the form:=0A=
=0A=
if (ctrlpriv->soc_data->need_ipg_clk)=0A=
     ctrlpriv->caam_ipg =3D devm_clk_get("ipg");=0A=
=0A=
You could even make all clks optional and claim that if a clk is not =0A=
listed in DT then it's assumed to be always on. However that means that =0A=
on some SOCs if DT is incorrect you can get a hang (due to missing clk) =0A=
instead of a probe error.=0A=
=0A=
> +	clk_disable_unprepare(ctrlpriv->caam_ipg);=0A=
> +	if (ctrlpriv->caam_mem)=0A=
> +		clk_disable_unprepare(ctrlpriv->caam_mem);=0A=
> +	clk_disable_unprepare(ctrlpriv->caam_aclk);=0A=
> +	if (ctrlpriv->caam_emi_slow)=0A=
> +		clk_disable_unprepare(ctrlpriv->caam_emi_slow);=0A=
=0A=
Clock APIs have no effect if clk argument is NULL, please just drop =0A=
these if statements.=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=