Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Jun 2019 10:32:01 -0400 (EDT)
From:   Nicolas Pitre <nico@fluxnic.net>
To:     Gen Zhang <blackgod016574@gmail.com>
cc:     Greg KH <gregkh@linuxfoundation.org>, kilobyte@angband.pl,
        textshell@uchuujin.de, mpatocka@redhat.com, daniel.vetter@ffwll.ch,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] vt: fix a missing-check bug in con_init()
In-Reply-To: <20190612134449.GA4015@zhanggen-UX430UQ>
Message-ID: <nycvar.YSQ.7.76.1906121018340.1558@knanqh.ubzr>
References: <20190612131506.GA3526@zhanggen-UX430UQ> <20190612133838.GA7748@kroah.com> <20190612134449.GA4015@zhanggen-UX430UQ>
User-Agent: Alpine 2.21 (LFD 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 12 Jun 2019, Gen Zhang wrote:

> On Wed, Jun 12, 2019 at 03:38:38PM +0200, Greg KH wrote:
> > On Wed, Jun 12, 2019 at 09:15:06PM +0800, Gen Zhang wrote:
> > > In function con_init(), the pointer variable vc_cons[currcons].d, vc and 
> > > vc->vc_screenbuf is allocated by kzalloc(). However, kzalloc() returns 
> > > NULL when fails. Therefore, we should check the return value and handle 
> > > the error.
> > > 
> > > Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> > > ---
> > 
> > What changed from v1, v2, and v3?
> Thanks for your timely response. I am not a native English speaker, so
> I am not sure I understand this correctly. Does this mean that I should
> use "v5", rather than "v4"? 

Given that this is your v4 patch, you should list what has changed since 
earlier versions. Greg is asking you to produce a v5 with that 
information added. Obviously, the change from v4 to v5 would be 
something like "added version change information".

> > That always goes below the --- line.
> And I can't see what goes wrong with "---". Could you please make some
> explaination?

The version change information should be put below the --- line in your 
post, not above it. This way it won't be captured in commit log.


Nicolas