Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5939323ybi; Wed, 12 Jun 2019 11:03:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqxrdY9c5UOfH/EYRr+XH1SH1MpXbsXWgkQTexRD+G6lhMmRHG7GXHRoI+g/XhToLqstL4fJ X-Received: by 2002:a63:6647:: with SMTP id a68mr26066995pgc.414.1560362621846; Wed, 12 Jun 2019 11:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362621; cv=none; d=google.com; s=arc-20160816; b=sq9x5Kt/yYljAOmNflzi5pb9Yrjl/KNvsSjUHfb2SxQ0It+73SKKe26sXJMuYmSgdK S/EgA/B2q7HH8s6QP/lBjys0aOHuEyGwQ3uaFqZrk7j12nIUzb/k9VvZiCLnre9Q3Bef +s3z9zDFq1lXiZu80DefurPfORAuXw/6IBK2JJR/UreQ/nnlviniUOSzWOEVqHtgjbbG XtlxPtKeoXm7e2moYrZh5QUVYpBg8lWE7ZYTHE8YEI7wGkp2old/T2LWtf69ISs+X+E4 7eNRQTkDrepbUL2rnF1eSxY3mLEAzXn14wnqsRW/L414EFwXcjKTkA45Tel+g9YlPEar qR6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=eOV7NtN2jo/XkectdmgWrdc58EbGemFPJxY+HaJCYxU=; b=qtSkLDTQPLTOF1XtPHPasosajVzSIAlN4xj2M3D4F+NK2DgK6V1ldj6iprfMGjwpwu ku32rnmViwlACxO4jLPZ+gXrQQd7wRIGvKwu5Pm53xPib3NKeFsBlfB6YJT+nazfbLfy p59fgD2ezBoz6JJ+cFUkIzAylC5506ejibi4NiLa9VVeezBXWdFKoz+jT2vWqpHUEmA3 RXcDet9Z4KhkS2WTh8kuZLQzAl8iu7IE66x/zavDtXcaDPwYwMVttkMayAP5X+02Tiax J8C+I89PweDWoojWiKH3c3U9l9KZBmaMrt9IpUvGtxizS+xhQpsqVDNtZVQeTwCodBYL kqlw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w184si401893pfw.271.2019.06.12.11.03.27; Wed, 12 Jun 2019 11:03:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729588AbfFLOoN (ORCPT + 99 others); Wed, 12 Jun 2019 10:44:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48558 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727846AbfFLOoN (ORCPT ); Wed, 12 Jun 2019 10:44:13 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4CD033087958; Wed, 12 Jun 2019 14:44:07 +0000 (UTC) Received: from oldenburg2.str.redhat.com (unknown [10.36.118.125]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C4DF6061E; Wed, 12 Jun 2019 14:43:59 +0000 (UTC) From: Florian Weimer To: Mathieu Desnoyers Cc: carlos , Joseph Myers , Szabolcs Nagy , libc-alpha , Thomas Gleixner , Ben Maurer , Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , Will Deacon , Dave Watson , Paul Turner , Rich Felker , linux-kernel , linux-api Subject: Re: [PATCH 1/5] glibc: Perform rseq(2) registration at C startup and thread creation (v10) References: <20190503184219.19266-1-mathieu.desnoyers@efficios.com> <87muj2k4ov.fsf@oldenburg2.str.redhat.com> <1528929896.22217.1559326257155.JavaMail.zimbra@efficios.com> <87o93d4lqb.fsf@oldenburg2.str.redhat.com> <117220011.27079.1559663870037.JavaMail.zimbra@efficios.com> <87wohzorj0.fsf@oldenburg2.str.redhat.com> <1329439108.43041.1560348962006.JavaMail.zimbra@efficios.com> <87blz27uio.fsf@oldenburg2.str.redhat.com> <512441263.43096.1560350163180.JavaMail.zimbra@efficios.com> Date: Wed, 12 Jun 2019 16:43:58 +0200 In-Reply-To: <512441263.43096.1560350163180.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Wed, 12 Jun 2019 10:36:03 -0400 (EDT)") Message-ID: <8736ke7tjl.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 12 Jun 2019 14:44:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mathieu Desnoyers: > ----- On Jun 12, 2019, at 4:22 PM, Florian Weimer fweimer@redhat.com wrote: > >> * Mathieu Desnoyers: >> >>>> It's the registration from libc.so which needs some care. In >>>> particular, we must not override an existing registration. >>> >>> OK, so it could check if __rseq_abi.cpu_id is -1, and only >>> perform registration if it is the case. Or do you have another >>> approach in mind ? >> >> No, __rseq_abi will not be shared with the outer libc, so the inner libc >> will always see -1 there, even if the outer libc has performed >> registration. >> >> libio/vtables.c has some example what you can do: >> >> /* In case this libc copy is in a non-default namespace, we always >> need to accept foreign vtables because there is always a >> possibility that FILE * objects are passed across the linking >> boundary. */ >> { >> Dl_info di; >> struct link_map *l; >> if (!rtld_active () >> || (_dl_addr (_IO_vtable_check, &di, &l, NULL) != 0 >> && l->l_ns != LM_ID_BASE)) >> return; >> } >> >> _IO_vtable_check would have to be replaced with your own function; the >> actual function doesn't really matter. >> >> The rtld_active check covers the static dlopen case, where >> rtld_active () is false in the inner libc. > > Then out of curiosity, would it also work if I check for > > if (!__libc_multiple_libcs) > > in LIBC_START_MAIN ? In my experience, __libc_multiple_libcs is not reliable. I have not yet figured out why. Thanks, Florian