Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5939348ybi; Wed, 12 Jun 2019 11:03:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwXqnIuocQsWUp8Y2W/SLm4Wo8Dd3T6eKrJfn65o+WL9/WemudWJpDwN5f5lnt6+++A1JAq X-Received: by 2002:a17:902:9a90:: with SMTP id w16mr80756378plp.113.1560362623540; Wed, 12 Jun 2019 11:03:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362623; cv=none; d=google.com; s=arc-20160816; b=P/mlJXT4dFI2aWRNt/Q7UN0KX1la61M9wDGuTWK9occAA93n82ZdJAxbEa0hoG2EVT 1Ro2pRyVI172h7880BvSSHBQckXjRLOCNSh7OWOSSAGVYclYoXcQPdVmUiGU2WqslR5s +7KLK3ts33Puy6ONeKoExxsU1CpOWC/xwSnqYawGhoWrLZYDQu3uvbl1UO2yKyqeLjv2 c1av4UEa9GmnYRDiBse3oLjLV78V6BDP/DTjtB9a1WsgWwGhGrd9+Yzt+MyDAVKdRjT2 PVDD3CZ1wzRd2lEujdDG6iQBDq+o7eVm8BRsqmNaHB0R5LbS2CfVF5WMLvgsWhZXbo+V kIsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=UnCZ3rkGOueMU9cIfREZEjfjq6fG3qQ6X9pr2gyfSiw=; b=qrABUYW69haeDQF2cbvD1pmmwhBWYQn726mUnCusD1ZJXYmr0yruPryJnyZ7wUjC4p JSifo+vI7VfgRoKfUYdub3IL1+wQ0p9mlyE3yHIEbq/KrVVgBhwrcdnjqB/sYgLGTEAK plmEJT5LNyiRk36iEyAb0jwUZP/SkPDmAcMPcIAtiHNtoMbr3DeaB7s9OE8skPPcR4e1 JVdLNYhqwDYunHH4GIAXaCEaZCBLBehckEosTrM+zngk2dls7UnyNlfIwWhgwnRGY7Pl rZz0xM5YoJNjfkkHkf/cKENav9Z2RHDYZOpNrivcP9pFJKO6xPHQ44s6qUyrRTYFMTHS 81rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 34si311889plp.305.2019.06.12.11.03.29; Wed, 12 Jun 2019 11:03:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408843AbfFLOtA (ORCPT + 99 others); Wed, 12 Jun 2019 10:49:00 -0400 Received: from www62.your-server.de ([213.133.104.62]:45262 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727121AbfFLOs7 (ORCPT ); Wed, 12 Jun 2019 10:48:59 -0400 Received: from [88.198.220.132] (helo=sslproxy03.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hb4YT-0007ga-Sh; Wed, 12 Jun 2019 16:48:49 +0200 Received: from [178.199.41.31] (helo=linux.home) by sslproxy03.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1hb4YT-0001m9-Hf; Wed, 12 Jun 2019 16:48:49 +0200 Subject: Re: [PATCH bpf] xdp: check device pointer before clearing To: Ilya Maximets , netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, bpf@vger.kernel.org, xdp-newbies@vger.kernel.org, "David S. Miller" , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson References: <20190607172732.4710-1-i.maximets@samsung.com> From: Daniel Borkmann Message-ID: Date: Wed, 12 Jun 2019 16:48:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190607172732.4710-1-i.maximets@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.3/25478/Wed Jun 12 10:14:54 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2019 07:27 PM, Ilya Maximets wrote: > We should not call 'ndo_bpf()' or 'dev_put()' with NULL argument. > > Fixes: c9b47cc1fabc ("xsk: fix bug when trying to use both copy and zero-copy on one queue id") > Signed-off-by: Ilya Maximets Applied, thanks!