Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Jun 2019 17:13:12 +0200
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Shobhit Kukreti <shobhitkukreti@gmail.com>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Jingoo Han <jingoohan1@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: backlight: Replace old GPIO APIs with GPIO
 Consumer APIs for sky81542-backlight driver
Message-ID: <20190612151312.GB5030@ravnborg.org>
References: <20190612043229.GA18179@t-1000>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190612043229.GA18179@t-1000>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Shobhit

> -	if (gpio_is_valid(pdata->gpio_enable)) {
> -		ret = devm_gpio_request_one(dev, pdata->gpio_enable,
> -					GPIOF_OUT_INIT_HIGH, "sky81452-en");


> +	pdata->gpiod_enable = devm_gpiod_get(dev, "sk81452-en", GPIOD_OUT_HIGH);
> +	if (IS_ERR(pdata->gpiod_enable)) {
> +		long ret = PTR_ERR(pdata->gpiod_enable);

In the old code the property was named "sky81452-en".
In the new code the property is named "sk81452-en".

Most likely a bug.

	Sam