Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5939646ybi; Wed, 12 Jun 2019 11:03:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyw1hnTcJzPS0B8WpgRWTW9Diue8ihZwfDsV7a4myLFjxliG26eZiErgoqE/HWAYaQdS4QO X-Received: by 2002:a63:6ec1:: with SMTP id j184mr10307381pgc.225.1560362637884; Wed, 12 Jun 2019 11:03:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362637; cv=none; d=google.com; s=arc-20160816; b=GETJPbKK2N0PQ758SO6WAwImuh4mjOQ5Q+qgHvdPfKpH9rffm6cI01Xbs2x9v7TC6E NgYpy0wnh+lDEh8tEEulI+KO0HjMMGLgEcaoPX3yBVTA6MRWNSrd+NP5kFE/q3eDmiwe sP8i4hP1AI4MoYHUv+7g6ay6k1lMp93iFBbmwlig28Y9jO27TcKEChcFHztnz0kziQHg 6yrW6IdAElcd8YI8+gQ2g28ZEaNhEjQu8s6J/QsT3Wvd5DRVd/ypxrD2VAQPn8Vre1r0 B/m9RxpnxI9wK+7ILYMnp7zCOiav0wwdYBzLl5uowAm6OWPRK2K6yLdsn2cxqW1YmSUY z8Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=S/GB4a5TSispNPGgoL6ZNAOrf6nS5uurvxT3ihYPD/Y=; b=BhY2b5U5XCkvmt7xaxiSWdeCw2qmSTE2v6udAzqO/q0Ddr6EwhdFf2qoV/XewvKyMm DxQQ3dA8lpEwakJDnrguaoDV+/NKqCobsvfBXNWrANgd/+tiZgVat5fuvES6t2A/vHRG DRs9e8aPrGFdKpFyMZK4uzZTsvKJbcOj79pfOqf276X8PkKqNaBmsiaej6sK1Lp49NFF lmwFQVrFFDPS8VnDNKmpgdwoFqOtXgic0OLJXdTkVzPJX5BNmHfmDo+MOekXmKgE0SHE apMg4Iq0l8FmrE62RdbHcpLKm2urPXmAhVwzjh9jjd3AaeuVeg4NRpFX8xVJAZMw9juf zcBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=GbbVQq0D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d9si389195pgj.505.2019.06.12.11.03.43; Wed, 12 Jun 2019 11:03:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=GbbVQq0D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728700AbfFLPOZ (ORCPT + 99 others); Wed, 12 Jun 2019 11:14:25 -0400 Received: from mail-yw1-f66.google.com ([209.85.161.66]:38052 "EHLO mail-yw1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728203AbfFLPOZ (ORCPT ); Wed, 12 Jun 2019 11:14:25 -0400 Received: by mail-yw1-f66.google.com with SMTP id k125so604338ywe.5 for ; Wed, 12 Jun 2019 08:14:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S/GB4a5TSispNPGgoL6ZNAOrf6nS5uurvxT3ihYPD/Y=; b=GbbVQq0DRbYQmv73EzjW7DwgW/Urn4CFLavsKDLUU3dJtrrq/SV11swrqa2vQgovHb sCEuJuHq0m3yfssNENG6l9iL8xMzQL+9LNOd5hdgCWNWe4NFxuUX25G7UXppctTU66ha 5a2JsaD+G+Fb3bPRcPAxcFMfxQnp5rI2rAALrcmclQA6VHlzTAaEaHzRK3ItaPfW1MLk t6J/m3ZicM2QsoNeu9FH6VAkZYCzYV/jriV6ioCiK7JoRHWk65XRG/Zi5UjojjqTyCwX ZMwsW7wbCivUt2G5ojspc3XcAz0jICcQDcbHogxXeYqf3pddTWD6GZdFscVvk9VM7Dcu DpOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S/GB4a5TSispNPGgoL6ZNAOrf6nS5uurvxT3ihYPD/Y=; b=TPZR/XOg8xlLWlA2qglL4ghhZ8MUr65L2Ngns5MHNIEUM30Wwg4ugdZTSHRx28I0Tx DA5VlmZmdqA+ziHFMyLzN967Cxqz1leLNbN4xdNKcUq7fal0SuMi70tMps06FTU1LpEy me1pJoRI9OR36hEkfk7xUCOaZY7jczoHVxrKRAs76Rq3rdXAoaOMgFLIU0pf6MDQt1P2 A0NXXowmwTL65uD6yM4qu2XLTYlo/X2Mse3IrPID/bMxx+h0Yq2DFvMQqQG4swnx+SPs rqxR9dckMh8lnkRcIiGiyTNsVok4r2xyxTkIn/+XAo2iz1PDf4txFYauitWgov8D2VVk dZDQ== X-Gm-Message-State: APjAAAXtK2c28wC/oXG1Wxd19gfJXjKghe7hylsLmZuzuw1RDArwQL4v KflVI4kEAihYt5uNdFXMYV79cKIEPREWRwdzbQz3yw== X-Received: by 2002:a81:4c46:: with SMTP id z67mr31835690ywa.267.1560352462950; Wed, 12 Jun 2019 08:14:22 -0700 (PDT) MIME-Version: 1.0 References: <20190612142727.GA1710@ahmlpt0706> In-Reply-To: <20190612142727.GA1710@ahmlpt0706> From: Guenter Roeck Date: Wed, 12 Jun 2019 08:14:11 -0700 Message-ID: Subject: Re: [PATCH] gsmi: Replace printk with relevant pr_ To: Saiyam Doshi Cc: Greg Kroah-Hartman , linux-kernel , Aaron Durbin , Guenter Roeck , Duncan Laurie Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When running checkpatch on the attachment, I get lots of ERROR: DOS line endings plus WARNING: Possible unnecessary 'out of memory' message Hmm ... ok, the latter is a different issue, but it kind of contradicts "This also helps avoid checkpatch warnings". Guenter On Wed, Jun 12, 2019 at 7:27 AM Saiyam Doshi wrote: