Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5942669ybi; Wed, 12 Jun 2019 11:06:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzd22NGttexyTClty5/KAPIVlIek0F8SlO4gnemtqQ2N4M/c3Xr4W/YWOz29ozUkdzlrNxv X-Received: by 2002:a63:ee12:: with SMTP id e18mr26887509pgi.412.1560362808025; Wed, 12 Jun 2019 11:06:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362808; cv=none; d=google.com; s=arc-20160816; b=k2+e+lmAjkXiyE9kUTlJSvvvdfYi9Qf2emTRcIlecmY5vvw5symxAltCuWyaPNNE+i oAHdKZL2X1hZW2SGozmCYKm9lEiKZlmly0AW07TVfZrd/dXbnc88Pai5l+z26oMEvnzK 57IE00vlWHEGrkO3QGRo78RfVjZpXd3ZrgIqv4UE5hGPA2q1AuEChs+RyovipDNAYbUA s59OdqzdkP0zPDfOVjxDZQgZphbnp+pNajNADtEyzCWEgEq76y3de+gJIVNK/NL/48tO aBg1mX15DlND9xAdH9bgKSK66Cq+m36G8jTSHv27SUPWgXNM6hIeO09lhKKYJuEeKH+1 buDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=f7KHfDsg1UeUU3SlauxEFRMF5a22ZJ625MBbjBPpPCY=; b=ZfEZ9ELeqJN7dO1PWLiycqNqj0YuKJ18ePTOpyvqcoL4coI54dGVo/RhF0Z52lSuD+ w5HKghiKzUdDPmTrVL1ejLOJXLdZjqgiqg04lRnfSmM/2Ol4zoJ86rLMUJqTM2ogNsp5 TCdBrXUGkU5gSAISIUIo9KToWYjR5qRuWaJFaPzi68ZxPfnCfm5YxP37A0os3gKJ9YK+ o+6Hh37GWMgwKwoKXEgWJ3Ns9vR1ltVSD5/myl7Z4vWccZBgqnMkVpIYiUV9SjAMPDyl fyS+AzUZ3HI2S3h+HxjN0KNDhWfIVDD2htJDT6daQ2XRrbimaM31tD9zTojI85DzSg6u QGbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si376784pfc.155.2019.06.12.11.06.32; Wed, 12 Jun 2019 11:06:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440235AbfFLQZP (ORCPT + 99 others); Wed, 12 Jun 2019 12:25:15 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:37692 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437944AbfFLQZP (ORCPT ); Wed, 12 Jun 2019 12:25:15 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BCC581513DD13; Wed, 12 Jun 2019 09:25:14 -0700 (PDT) Date: Wed, 12 Jun 2019 09:25:07 -0700 (PDT) Message-Id: <20190612.092507.915453305221203158.davem@davemloft.net> To: maowenan@huawei.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com Subject: Re: [PATCH net v2] tcp: avoid creating multiple req socks with the same tuples From: David Miller In-Reply-To: <20190612035715.166676-1-maowenan@huawei.com> References: <20190612035715.166676-1-maowenan@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 12 Jun 2019 09:25:14 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mao Wenan Date: Wed, 12 Jun 2019 11:57:15 +0800 > diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c > index c4503073248b..b6a1b5334565 100644 > --- a/net/ipv4/inet_hashtables.c > +++ b/net/ipv4/inet_hashtables.c > @@ -477,6 +477,7 @@ bool inet_ehash_insert(struct sock *sk, struct sock *osk) > struct inet_ehash_bucket *head; > spinlock_t *lock; > bool ret = true; > + struct sock *reqsk = NULL; Please preserve the reverse christmas tree local variable ordering here. Thank you.