Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5945391ybi; Wed, 12 Jun 2019 11:09:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqzKKBLpujT5dVAnAn8xDa1pJXaT0rUbVzPgmew9KeS/6PnkncMkQNsXWitXOiK1LLqWx4iZ X-Received: by 2002:a63:1c59:: with SMTP id c25mr448663pgm.395.1560362948104; Wed, 12 Jun 2019 11:09:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560362948; cv=none; d=google.com; s=arc-20160816; b=jDnwYVCuR0zUxmYOpe1DO3oLGu138aoe8EwY/+BFsN5crrymtQ1bCe0BwS5C9uXjNq nYL4k1A4BxJQxL18DaueW+crfnI7y6FWKVYqPOJ22aYmvFRoBfjGb9YwLL3EakDm2Kb4 IH6WlFA5TVNSBWFRGCTsEVckt2A0Cn9LHbpdQd1z0PM0rgGa0PVnwQRdaklo46umMV46 tBJjY+l0Y7sCQsGPyXQTh09gimIfPaee+viVJVmT0L+Avsu8RLn8+QzIem5Br5EJizOM o4Ivwh3chF9wlP9IHtiUjiNHoP7ZgU60jIwbcFBxQjR5r+DkWPwbKlBufcQA4mLsCl52 UpGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=dCHCeocAmL6meM9qjy9P1A8GdY5XSX6cnD5creDeSTs=; b=dHBoWEmMApJD5TADi4IMLV5hwv18RFGF2pSNslQ9EqzZUrQTA4B82s+QX7GY8YacyC 4Pdgfym0qGUrWxBcuFTHslyqn+9LLKf2Mw7tOh0Z4DfywUsBLw5B8/iGxJViC2S1g636 0/lW7GFlYmwq6jC/JQuSNFsGxxrzeYJ9kQ3s4px7R/DPJ3BekzseBs7oDjMD+yfMFvWA mp1Q0WzRZdn7bA6AJgi/gI3J171xPuDj0M4C3YZXSPP0/vKpP9HelIGcGl7KKpa+g/G5 dXMiW5tXp+LE6SsBr/tkzGVgRw4f71Eb2vsQT2volVAWPNlPDKYv/7k4ILI9AB61DkRq B0+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ch14si336099plb.44.2019.06.12.11.08.53; Wed, 12 Jun 2019 11:09:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408013AbfFLR3S (ORCPT + 99 others); Wed, 12 Jun 2019 13:29:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:53478 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2406395AbfFLR3S (ORCPT ); Wed, 12 Jun 2019 13:29:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id C45A5AEBB; Wed, 12 Jun 2019 17:29:16 +0000 (UTC) Date: Wed, 12 Jun 2019 19:29:15 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Matthew Wilcox Cc: gorcunov@gmail.com, linux-mm@kvack.org, Laurent Dufour , linux-kernel@vger.kernel.org, Kirill Tkhai Subject: Re: [RFC PATCH] binfmt_elf: Protect mm_struct access with mmap_sem Message-ID: <20190612172914.GC9638@blackbody.suse.cz> References: <20190612142811.24894-1-mkoutny@suse.com> <20190612170034.GE32656@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dc+cDN39EJAMEtIO" Content-Disposition: inline In-Reply-To: <20190612170034.GE32656@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dc+cDN39EJAMEtIO Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 12, 2019 at 10:00:34AM -0700, Matthew Wilcox wrote: > On Wed, Jun 12, 2019 at 04:28:11PM +0200, Michal Koutn=FD wrote: > > - /* N.B. passed_fileno might not be initialized? */ > > + >=20 > Why did you delete this comment? The variable got removed in d20894a23708 ("Remove a.out interpreter support in ELF loader") so it is not relevant anymore. --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEE+amhwRV4jZeXdUhoK2l36XSZ9y4FAl0BNl8ACgkQK2l36XSZ 9y4uOxAAjMDNYmUD6lLGAzeXFrP+1e5ZsH+N+j2Qh62Pahnv0oBIbre4TBhAk4xm av5IPuXrU5Ov5DrRGwDlDP1B2gHbCsvkMxjN+fhrqDRaP9q2y1+UIwKJD66VTxIQ KiEEiU0uZvikSW4/s4OWstiLxj9nZmiun/YiJ5qVNVuvsfoUjvTHK0BbAN6Vdaab M80HDqLf+uuERUiaSb8xa5WVB0QViHICBJ2LDfDnVtiioJPn44kPmFwyao+nZJ1T /RlZ9jFB0UIFSRWIwAxA+qwyWj2hlfT3NC8DMqROJzQDwje6op8keLSWJnwWGMzG OldDk2uRA5DUi3nliUhp6iv8fDgcryT0IvV5GsphE/LHU/xVMymC0ZkIMksTq4pG cWU1rnWOLgDpr9BHzP2Zhl7RjSyPUNBojV/hVvo0hpPt2gFgQOlhegKkKl/pURjG jsLbYKr9aA99OJUEIfk4qK019j6b2If2Ixh5FyXAcxzDpQWIMWAaZdyoFkytnYK9 tKW0uHeCA6irmDKIAQiXfftfLH+UnZtgyOC6LPv17R708LxUpaoUTANh0tP6oLv5 JSABgDwjlbdD9Z9IAfpwOXlbiy5SNyVj68KnZqOfdr0Fb8RVcZ1cLDL8l/EV5COV 40ZmE+Enx5DK9cL9+pTYqi2EPAq96UEZnWOWP9D9s8F2bxjBOAA= =67iw -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--