Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp5948114ybi; Wed, 12 Jun 2019 11:11:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRom2Yz6MGOYcLAbPJ0IFsLbkyiO68NPazvSUPVxyc0/keIODGAeFeaKXzjEfn2kNlEeub X-Received: by 2002:a62:1993:: with SMTP id 141mr85168863pfz.97.1560363095678; Wed, 12 Jun 2019 11:11:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560363095; cv=none; d=google.com; s=arc-20160816; b=o/2YoljWjmq2v5S7tFdO5jxAmhtdAWC+WbMBMrfAdyiuK/+Sm3/EqNB1xLScjxToW0 XWe8krW0ewO+aZmnTXzkZnKmUK0wXDo2eopSQii24gomofaiL0BkrkvSdf63ZOBkGZxm MBC9G/iL1Dsspv1/DVaV+YeTkLorlL9ieewH9NsSrCXV859nfiel2FZilwXLTtwCfYAJ U6jmNET/E9IyV32ZjMQug0vBZ6jGODNTi2JS+LAfxY+WFwm8ncqoqk62RGsjuhCG/Nb+ PlYsZ2VE1/RgNeo462cfpQ1BimMroH4S0VK0aVwKDwzpKjqEm8aiW60USab5YK8c9Fs6 FUZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Lyj/twIUMfRZLnycvXCAwKVqXb+AnVXqb5crH2VL7xw=; b=N+KgbMmxHmJzyS8WZQ7xxzD5XmAl2Ej4KZJ4AqrGGsAFQ5NWB1yBX605r3d/LQ4x1z yFKUVqlFFCFmVL9Eb6nEB07XMMNc3fgAwZrOLjxTM9fgEq+hpumsu1ji6ux+i1ykJ4WC bTTpg84vfiioQv7qWilr+3rjohGVCGNKGl60zEDXht4Zo5hcUXRRz/gMrbexGW3uQl9Y f2YQvR9NEya8NxS+i0c/KrdgDGmsPBOYPjEYsdwNXr9n2Fc9PbevF6u3z6IpA57e1h0H LF3IKtl406LdExXwx79jQ8d9N3XNyNxFu9aSRHL9iGje6qKdKKmMhk09awKMSiJ4bgyY JcVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 63si382097pfe.121.2019.06.12.11.11.20; Wed, 12 Jun 2019 11:11:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729072AbfFLSBn (ORCPT + 99 others); Wed, 12 Jun 2019 14:01:43 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:39272 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728019AbfFLSBn (ORCPT ); Wed, 12 Jun 2019 14:01:43 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 90FD71527F8C9; Wed, 12 Jun 2019 11:01:42 -0700 (PDT) Date: Wed, 12 Jun 2019 11:01:42 -0700 (PDT) Message-Id: <20190612.110142.1987648912531453321.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, ioana.ciornei@nxp.com, olteanv@gmail.com, rmk+kernel@armlinux.org.uk, andrew@lunn.ch, vivien.didelot@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: Deal with non-existing PHY/fixed-link From: David Miller In-Reply-To: <20190610193150.22231-1-f.fainelli@gmail.com> References: <20190610193150.22231-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 12 Jun 2019 11:01:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Mon, 10 Jun 2019 12:31:49 -0700 > We need to specifically deal with phylink_of_phy_connect() returning > -ENODEV, because this can happen when a CPU/DSA port does connect > neither to a PHY, nor has a fixed-link property. This is a valid use > case that is permitted by the binding and indicates to the switch: > auto-configure port with maximum capabilities. > > Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports") > Signed-off-by: Florian Fainelli Applied.