Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190612170647.43220-1-sathyanarayanan.kuppuswamy@linux.intel.com>
In-Reply-To: <20190612170647.43220-1-sathyanarayanan.kuppuswamy@linux.intel.com>
From:   Myron Stowe <myron.stowe@gmail.com>
Date:   Wed, 12 Jun 2019 12:15:49 -0600
Message-ID: <CAL-B5D0BF4z-H5Knj-88BBMh5Oh_cW+mT5_AE8ySrtpsZnTtBA@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] PCI/IOV: Fix incorrect cfg_size for VF > 0
To:     sathyanarayanan.kuppuswamy@linux.intel.com
Cc:     Bjorn Helgaas <bhelgaas@google.com>,
        linux-pci <linux-pci@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, ashok.raj@intel.com,
        Keith Busch <keith.busch@intel.com>, mike.campin@intel.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This looks to basically be a duplicate of what Alex Williamson posted
8 days ago: https://lore.kernel.org/linux-pci/20190604143617.0a226555@x1.home/
Alex says Hao Zheng had a similar patch as well.

On Wed, Jun 12, 2019 at 12:08 PM
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
>
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Commit 975bb8b4dc93 ("PCI/IOV: Use VF0 cached config space size for
> other VFs") calculates and caches the cfg_size for VF0 device before
> initializing the pcie_cap of the device which results in using incorrect
> cfg_size for all VF devices > 0. So set pcie_cap of the device before
> calculating the cfg_size of VF0 device.
>
> Fixes: 975bb8b4dc93 ("PCI/IOV: Use VF0 cached config space size for
> other VFs")
> Cc: Ashok Raj <ashok.raj@intel.com>
> Suggested-by: Mike Campin <mike.campin@intel.com>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
>
> Changes since v1:
>  * Fixed a typo in commit message.
>
>  drivers/pci/iov.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c
> index 3aa115ed3a65..2869011c0e35 100644
> --- a/drivers/pci/iov.c
> +++ b/drivers/pci/iov.c
> @@ -160,6 +160,7 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id)
>         virtfn->device = iov->vf_device;
>         virtfn->is_virtfn = 1;
>         virtfn->physfn = pci_dev_get(dev);
> +       virtfn->pcie_cap = pci_find_capability(virtfn, PCI_CAP_ID_EXP);
>
>         if (id == 0)
>                 pci_read_vf_config_common(virtfn);
> --
> 2.21.0
>