Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190422183056.16375-1-leoyang.li@nxp.com> <20190510030525.GC15856@dragon>
In-Reply-To: <20190510030525.GC15856@dragon>
From:   Li Yang <leoyang.li@nxp.com>
Date:   Wed, 12 Jun 2019 15:01:29 -0500
Message-ID: <CADRPPNT2G20j2pvSEyqX=_WNDPrcNR+xCR_XZukbnSW19wFLNA@mail.gmail.com>
Subject: Re: [PATCH] arm64: defconfig: Enable FSL_EDMA driver
To:     Shawn Guo <shawnguo@kernel.org>, madalin.bucur@nxp.com,
        Rob Herring <robh+dt@kernel.org>, aisheng.dong@nxp.com
Cc:     Vinod Koul <vkoul@kernel.org>, Grant Likely <grant.likely@arm.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, May 9, 2019 at 10:15 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Apr 22, 2019 at 01:30:56PM -0500, Li Yang wrote:
> > Enables the FSL EDMA driver by default.  This also works around an issue
> > that imx-i2c driver keeps deferring the probe because of the DMA is not
> > ready.  And currently the DMA engine framework can not correctly tell
> > if the DMA channels will truly become available later (it will never be
> > available if the DMA driver is not enabled).
> >
> > This will cause indefinite messages like below:
> > [    3.335829] imx-i2c 2180000.i2c: can't get pinctrl, bus recovery not supported
> > [    3.344455] ina2xx 0-0040: power monitor ina220 (Rshunt = 1000 uOhm)
> > [    3.350917] lm90 0-004c: 0-004c supply vcc not found, using dummy regulator
> > [    3.362089] imx-i2c 2180000.i2c: can't get pinctrl, bus recovery not supported
> > [    3.370741] ina2xx 0-0040: power monitor ina220 (Rshunt = 1000 uOhm)
> > [    3.377205] lm90 0-004c: 0-004c supply vcc not found, using dummy regulator
> > [    3.388455] imx-i2c 2180000.i2c: can't get pinctrl, bus recovery not supported
> > .....
> >
> > Signed-off-by: Li Yang <leoyang.li@nxp.com>
>
> Applied, thanks.

Hi Shawn,

Is it possible to move this patch to the -fix series so that it can
reach the mainline earlier?  It is having a boot failure in mainline
for platforms using this device without this workaround.

I see Rob added a new API driver_deferred_probe_check_state() last
year.  Probably we should update the imx-i2c driver to use the new API
for optional dependencies to avoid this kind of situation completely?

Regards,
Leo