Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] drm/bridge: analogix_dp: possible condition with no
 effect (if == else)
To:     Hariprasad Kelam <hariprasad.kelam@gmail.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <9bcf16dd-c064-27eb-3749-c3933b4b605f@samsung.com>
Date:   Thu, 13 Jun 2019 15:09:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190525175937.GA29368@hari-Inspiron-1545>
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20190525175948epcas2p31156b3ec2ee712634558e04faa42b342@epcas2p3.samsung.com>
        <20190525175937.GA29368@hari-Inspiron-1545>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25.05.2019 19:59, Hariprasad Kelam wrote:
> fix below warning reported by coccicheck
>
> ./drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1414:6-8: WARNING:
> possible condition with no effect (if == else)
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>


Mixed feelings about it, but:

Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>


I will queue it to drm-misc-next.
 --
Regards
Andrzej


> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 257d69b..cfcd159 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1411,8 +1411,6 @@ static void analogix_dp_bridge_mode_set(struct drm_bridge *bridge,
>  		video->color_space = COLOR_YCBCR444;
>  	else if (display_info->color_formats & DRM_COLOR_FORMAT_YCRCB422)
>  		video->color_space = COLOR_YCBCR422;
> -	else if (display_info->color_formats & DRM_COLOR_FORMAT_RGB444)
> -		video->color_space = COLOR_RGB;
>  	else
>  		video->color_space = COLOR_RGB;
>