Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7034601ybi; Thu, 13 Jun 2019 08:28:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxvYr+M65H+SZkWrGfvM5AWslk5viNt4yzCcxzsiyRJvV2uMrGB6ZS9173ymZzwJZ7Mj7qa X-Received: by 2002:a62:5105:: with SMTP id f5mr93841533pfb.127.1560439736702; Thu, 13 Jun 2019 08:28:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560439736; cv=none; d=google.com; s=arc-20160816; b=MS4gc9Z9aDVvXv9m9xEgyupAV6UYhgp6Xx9RHF4A/9rAzA24VTQejR//LIm34Lcw9H OvDPjp+kv7xttQw9sAbMteVRImACX14kv4cim9hznStMFuSN4N7zHPLI6h6LskLFtTa3 a89Ou3v/qmPP5MevWUOug6eDOji9wxKgu9QsrNp+V4WdZskcCe/TGLHNKqd+/X+acLBd VaRnJpbPMrNOVctF/7wLLavqCr0btDgH3IPCC3DZw4gdSN0IGf6ecEZ9HHAMH06oivmR smF1OeHd5cM/hzyi8wikbmtj58RM6JwSmbsR5n6eP2GXJxupLVEEDZWiMiLKkJtaBNlc nVXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=AF1205N89OZNViaP6acWXh6mHKPDql5m0Yi3tu1T8h8=; b=U3YOZJrfRXi7KygC92kasa6g/wmpzhx7oPcN3DARD7DrMZsMcXC8qEpukUrqBiizM5 yCOeWc/4ncHMr999lQ2t3O/le7RnAFu3J/Zc6MTC1J78RPzW8OEB+YdTG/3+nRKiBZ9E vJjrUajqYiZxmH61a5uWIgz1doZQjfGyA1cPbmeCKewb0gAdEv0wsJeuqkXE/GhsS76a j/bvquG5WGLyLDLZLwIF//X1XxFkCIsj4FqCExk6+a0eHnjlFS0WTQdYUmkQE6lbk1Wo vYCUyudnLCRhjOo0gX15ajnbpVWqUfZWaNxr19zJrA+0yH2tH7zFkVcsmH0VzFGt/a1q JJww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cloudflare.com header.s=google header.b="TbGt75o/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=cloudflare.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 29si63201pgy.132.2019.06.13.08.28.41; Thu, 13 Jun 2019 08:28:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cloudflare.com header.s=google header.b="TbGt75o/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=cloudflare.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729877AbfFMP1v (ORCPT + 99 others); Thu, 13 Jun 2019 11:27:51 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37798 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728990AbfFMLc7 (ORCPT ); Thu, 13 Jun 2019 07:32:59 -0400 Received: by mail-wr1-f67.google.com with SMTP id v14so20368646wrr.4 for ; Thu, 13 Jun 2019 04:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AF1205N89OZNViaP6acWXh6mHKPDql5m0Yi3tu1T8h8=; b=TbGt75o/WSp1OSUJTHNYCciigYJKAYY6solbnb+OPu7egwRHpZFyTp57t0BC1acpgS TAPKFVoWfjLIyWlG5lM6ccnEx04BY1qZTdskF0iD/gBFok1EC4Jb4k98qIWfHxkzKXFg UCMZerFSt04ZfSvT63r76NMFvJdbfCUTVST3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AF1205N89OZNViaP6acWXh6mHKPDql5m0Yi3tu1T8h8=; b=ZQI7oA+bIQ9cJMuJqgRYU5xqlmoAOhwhCTiQt0NJey/ktFB99uj5kA+NfhT9Q777v/ 21g5ql12z1vYxkCiSTbc40rpS5e2zNPX6vjJpgcyDk0trXraTY2jyw2B72QY/fYMbL4h 7TqJV+opDBoaGb9E4t02Gh0plbrnRejpmJKtmTvUHtKTqpuWG+EcGMdg0FQblMJCgVeS gNRlPPg+Gtu2PvqdXHP0A0+lv6oP5wS0FEBYo4VtQbrAo3x1GS84rGU2mQ/e7mgTpn2D 9QtiAbg2rVmuh+GDVymw570dVXNfZKAMcsN7O1ObJvGt2tBsz9maQLGCBAP+PhdVAOBA n6zg== X-Gm-Message-State: APjAAAUDWFQ7f/BpdWqU2KKGRhQ1OORt+k/5timQHVBfuwnYT6EkU6np kmt/yt2O4x0KPGCW0Mo/hjGGtw== X-Received: by 2002:a05:6000:128f:: with SMTP id f15mr5748511wrx.196.1560425577814; Thu, 13 Jun 2019 04:32:57 -0700 (PDT) Received: from localhost.localdomain ([147.12.216.9]) by smtp.gmail.com with ESMTPSA id f2sm2646740wmc.34.2019.06.13.04.32.56 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 13 Jun 2019 04:32:57 -0700 (PDT) From: Arthur Fabre To: Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arthur Fabre Subject: [PATCH] bpf: selftests: Fix warning in flow_dissector Date: Thu, 13 Jun 2019 12:27:09 +0100 Message-Id: <20190613112709.7215-1-afabre@cloudflare.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Building the userspace part of the flow_dissector resulted in: prog_tests/flow_dissector.c: In function ‘tx_tap’: prog_tests/flow_dissector.c:176:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration] return writev(fd, iov, ARRAY_SIZE(iov)); ^~~~~~ write Include to fix this. Signed-off-by: Arthur Fabre --- tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c index fbd1d88a6095..c938283ac232 100644 --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c @@ -3,6 +3,7 @@ #include #include #include +#include #define CHECK_FLOW_KEYS(desc, got, expected) \ CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) != 0, \ -- 2.20.1