Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7036438ybi; Thu, 13 Jun 2019 08:30:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqx3d4dn8NGZo7IpvH+Rc7yumZeWqKp50VhgyZbl0e+YJWMYfjvnfacbMeyw0/3rnI0M8Eu1 X-Received: by 2002:a63:5c15:: with SMTP id q21mr17419809pgb.248.1560439839166; Thu, 13 Jun 2019 08:30:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560439839; cv=none; d=google.com; s=arc-20160816; b=h2CG3/4BBiX3C1YoAdH1tHi6o6KJBORQ8siA3OQrhbKOHikQ1Pp+lcyiQi/0VhCGF4 UL3MbTDq7rvfhOxmzV4KtYDHwPKKi2qbkQRMt40bQzwrQIIwhLUBnh8TRuG4ZcZR/Yy2 UMCysQaYO0eC+4WVwC7Ka3JBke3kfz874k3P93HksAwt5oabp8GdhS6mrY+lJSVYhazl imobPwiynbMNq41lWz9LikMvT7jUj+9elljAoe2v7tDXKLp9Jz94Pi4uwL6HpEuc1LV4 fkOqqaUp6U7iroCksL42HBk8o0XQwbd/nI5LpLaUbLx+xDiA01hMEXSDlPSBcI58fFgr 0fMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=1WAAagtMIpuMmntn9aDeR8FwerrN/7ALok5dNYHpevc=; b=FCQqpJeelL6j/eUpKPe+3LzBJchSzfbNBjZYMVmHG/KS82b4hiI1li7qigvyfO8+ZV qDe6Ob0qaFa+o/bAYewInVQDnIgCWhEwusPMv9Ms/k7q628OyjOoGzux4RxYK6GHlNcU hunhAqxcZFQImU20DuCSMYpIFaSvEoSuuy2sgM/ZwMlqUlHn2fft6fX4HM6d7QNEFPC1 +vGBmcRRAX0jdOGvWrfupmRHkc9gUdiDTKkl5gZ2pOep/9UNima7yO23aZXh2729ygav TiHNLpwXEUkHlgPnzm6S+IJrizHjuCLXjAUG7ysjBu7ASVv2sxR5TO2El274ExaXo/aJ zC9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si3353349pls.109.2019.06.13.08.30.23; Thu, 13 Jun 2019 08:30:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbfFMP3Y (ORCPT + 99 others); Thu, 13 Jun 2019 11:29:24 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:48982 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727226AbfFMP3V (ORCPT ); Thu, 13 Jun 2019 11:29:21 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DD32B84DFAD0ADBD21A3; Thu, 13 Jun 2019 23:28:59 +0800 (CST) Received: from localhost (10.133.213.239) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Thu, 13 Jun 2019 23:28:49 +0800 From: YueHaibing To: , , , , CC: , , YueHaibing Subject: [PATCH v2] media: ttpci: Fix build error without RC_CORE Date: Thu, 13 Jun 2019 23:23:19 +0800 Message-ID: <20190613152319.30076-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 In-Reply-To: <20190612152531.624cfba4@coco.lan> References: <20190612152531.624cfba4@coco.lan> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If RC_CORE is not set, building fails: drivers/media/pci/ttpci/av7110_ir.o: In function `av7110_ir_init': av7110_ir.c:(.text+0x1b0): undefined reference to `rc_allocate_device' av7110_ir.c:(.text+0x2c1): undefined reference to `rc_register_device' av7110_ir.c:(.text+0x2dc): undefined reference to `rc_free_device' Reported-by: Hulk Robot Suggested-by: Sean Young Fixes: 71f49a8bf5c5 ("media: ttpci: use rc-core for the IR receiver") Signed-off-by: YueHaibing --- v2: use depends on DVB_AV7110_IR instead of select as Sean Young's suggestion --- drivers/media/pci/ttpci/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/ttpci/Kconfig b/drivers/media/pci/ttpci/Kconfig index d96d4fa..8a362ee 100644 --- a/drivers/media/pci/ttpci/Kconfig +++ b/drivers/media/pci/ttpci/Kconfig @@ -1,13 +1,14 @@ # SPDX-License-Identifier: GPL-2.0-only config DVB_AV7110_IR bool + depends on RC_CORE=y || RC_CORE = DVB_AV7110 + default DVB_AV7110 config DVB_AV7110 tristate "AV7110 cards" depends on DVB_CORE && PCI && I2C select TTPCI_EEPROM select VIDEO_SAA7146_VV - select DVB_AV7110_IR if INPUT_EVDEV=y || INPUT_EVDEV=DVB_AV7110 depends on VIDEO_DEV # dependencies of VIDEO_SAA7146_VV select DVB_VES1820 if MEDIA_SUBDRV_AUTOSELECT select DVB_VES1X93 if MEDIA_SUBDRV_AUTOSELECT -- 2.7.4