Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7049791ybi; Thu, 13 Jun 2019 08:43:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqzXkDkYkB8VGSjH9vzFPVEZ8eib/4Aot5giIE8fVRgsuw8Snnnx+Wn6a0uA+rjub2urH9GG X-Received: by 2002:aa7:9087:: with SMTP id i7mr36672201pfa.40.1560440624032; Thu, 13 Jun 2019 08:43:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560440624; cv=none; d=google.com; s=arc-20160816; b=EisZ+7cV5wW9HcuF0m9TI9nYx1g7EDzADERB3gdHcVRbEp7y+yeTdWv/ty3Zbpq1CC yqOZdaoj8y9G5Pp6ejWuW2NElbqj3qwl2O1o6eDHoUF0bMmG8SoY6sYFOFFRv43RW3Sm 5T3FqnzIFOw+U25Ul8TaGeDJp/E7EoxGHdPLXwBhr2fr6BsbKALmeFrof0o5RjGrfmdB HHi11QUCnjRIb2mZa1ilwJdY+2KESbrxvfLZ+qblUJsnAn6R5FAVU468Ooh1ix+acw94 OTi6SGr0+0gBi4qPLE5p9FTEP4knhO51w7bGk7wueWkxwsTtKnTUrRwipw1mFi3xYL+q d4Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8fivmtrokbwW42BlJNZMuBqGS22ykfukEiehrk41ecw=; b=SgFn3sAzotVjxZ42l/0gKgBhspJ/b/fWC6kG/HALLElQdunanN9ETiLAtL0DVNOe0p 97szeZT8P7cGeDTc7OL8RauODm96RqkFKPOy8OZ7a2nfn2fNXbwxejkjyUn7MJNcMJvd SzQ+uASV/II0aU7wnXBKrT6oO1aCgAc0l5JKuA1S5TcUFJshQguxVWrD4Mn9iRsS2RC8 AqHTuUppuio1k17sb+LhysTWwubY6bEbOFU2SoAdHdFspzF6EKJgUxWsrlkOkVhGWj// jDlnxhMY6eN2FFa2jlQx9xqM6f6jZFkAYgoVAOTPmKUkqhrQZGmDAFSBLG8HN53Vz0dP hQdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="cmdZW/8M"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si84894pgv.280.2019.06.13.08.43.29; Thu, 13 Jun 2019 08:43:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="cmdZW/8M"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727232AbfFMPlW (ORCPT + 99 others); Thu, 13 Jun 2019 11:41:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:55196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731888AbfFMJup (ORCPT ); Thu, 13 Jun 2019 05:50:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0188E20896; Thu, 13 Jun 2019 09:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560419444; bh=PpeT9VU2erDRkCNoGBBH48Cc61wP3h71WxXB0A/GzrI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cmdZW/8MwTluVDoHeT+7w8rueLxvdgt+8NBIsT4o7FnT3svFK9XywHpFpyUYbWq+h cXhc4oeCpUshCeRJqh20FIJR6FCgQi1KwWmOCM8g47YUDa4a2SSU/ClXjLf9E5uE6E GO+sR1HRSaOg8C4TDpxCr4r9Z7LvUiCRLFc6Xvt4= Date: Thu, 13 Jun 2019 11:50:42 +0200 From: Greg Kroah-Hartman To: Hariprasad Kelam Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: rtl8723bs: hal: sdio_halinit: fix comparison to true/false is error prone Message-ID: <20190613095042.GA17445@kroah.com> References: <20190612022956.GA23698@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190612022956.GA23698@hari-Inspiron-1545> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 12, 2019 at 07:59:57AM +0530, Hariprasad Kelam wrote: > CHECK: Using comparison to false is error prone > CHECK: Using comparison to true is error prone > > Signed-off-by: Hariprasad Kelam > --- > drivers/staging/rtl8723bs/hal/sdio_halinit.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > Patch seems to be corrupt, please rebase and resend. thanks, greg k-h