Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7050554ybi;
        Thu, 13 Jun 2019 08:44:36 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwDd4NiiYF2HmdpkhkH8hdob4or9WMTKiGk15ApLtgLu2VsF+/G8VmIr6ip0WXUUaq1atgx
X-Received: by 2002:a17:90a:ac14:: with SMTP id o20mr6385972pjq.114.1560440676320;
        Thu, 13 Jun 2019 08:44:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1560440676; cv=none;
        d=google.com; s=arc-20160816;
        b=vAQXD/Bv67G2LfovKpVjZcBkxxG5n9uN9X5lc1hJKT+TtRGJAPKDIlTq39ckhxYAEP
         cufwgn7T82m8M+dS49mACwIyVHvB9Cf+Iuw7VVIer0IR+WQznVfG7cycw50HGXkTeWLh
         +vjedTqNry73WOnatExVG4qoojJGayxd9LyLFO/S5A9r5YaLimnUD/dRje805+lBl+H/
         C06Pp0ubeTDR4T6Ws7PQuj5ukYyBTW7HKTlrDWStFkS5v9kTpiIFNsr3lrHrGYsRmXs3
         MjYcDRJc0m0HAYDhTt7nH7P1bqw4cN39WhTDWkD55ymVwKQC74kMcO5Y+EJhZlWV35t+
         YdUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=YU12ByuLCH7tZ1jS2msDQtEv9owNHhqfDpUOtnT0e+w=;
        b=b4mBF5og12slOm4PMOpuBzmfmK5hyhAVPte+cMnOpZAxm78XSobC28I440OtoOnLKg
         tx/hE7i9PtX4R8as8/S9Y3T+LG40Dbg2Xj4FH/EvY3UbOpiVvfjNN/jLKpL4HFcCXW6j
         L1KAWU6eUoIFaPHK8i/EvuFEOcntqHkqdMd3elf7u0MqwLpotEtL3/AdtW5RarUkkMvg
         53Xrhe4q7JMvH1PAu8aBStPJaNX65QW6hytWErNXaFthl1RBNlVSBHNmEZaKvyGOUp8b
         UCPbAdIwi5/SoInkppNezX5upfpOxQa7xURUeyIf00MuYET1ZDXvi6HjiajwFu3wDtjE
         3A3w==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=lgD4LhRd;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id m12si41437pjq.67.2019.06.13.08.44.20;
        Thu, 13 Jun 2019 08:44:36 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=lgD4LhRd;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728409AbfFMPni (ORCPT <rfc822;mailist1go@gmail.com>
        + 99 others); Thu, 13 Jun 2019 11:43:38 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:17385 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1731835AbfFMJrL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Jun 2019 05:47:11 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d021b9d0001>; Thu, 13 Jun 2019 02:47:09 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 13 Jun 2019 02:47:09 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 13 Jun 2019 02:47:09 -0700
Received: from [10.25.72.199] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 13 Jun
 2019 09:47:06 +0000
Subject: Re: [PATCH v3 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes
To:     Jon Hunter <jonathanh@nvidia.com>, <thierry.reding@gmail.com>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>
CC:     <mkumard@nvidia.com>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1560417053-2966-1-git-send-email-spujar@nvidia.com>
 <8a71e670-7943-6bce-ba61-3f020fd9450d@nvidia.com>
From:   Sameer Pujar <spujar@nvidia.com>
Message-ID: <6a4b5fac-68cd-542a-a907-0d80713f9d82@nvidia.com>
Date:   Thu, 13 Jun 2019 15:17:02 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <8a71e670-7943-6bce-ba61-3f020fd9450d@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1560419230; bh=YU12ByuLCH7tZ1jS2msDQtEv9owNHhqfDpUOtnT0e+w=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=lgD4LhRd5386YjyITaBcYVW7w+koRR5FhTSRvhJkhUtDceodU4cowkY/Rj6o8pzXr
         uEJ8gzziTbeCtV4wcPmDTNyGukE9dAAANUIC9dPv9uiLDuhudhoE6VWmRxR8/3rFMQ
         2s5ha6EoUSkxbLpz0Hfsq7arNlTBJscLFmaCFIBL/ewCGIcdBJtJ2RSuStLr9R6Adu
         R/DqwY5zX2uhUMGkEqHiV/XhM1lKDufOmkI7V+MnX0zbVKpYW8hmP76QfZIuykiy2P
         fV4O+i3hGYojK3N1JdF6KIL1C2lnIo4wMwAEOPizdMq3fdm9JZXUXSi+c0pjW7W4PY
         nug4WV+hXY0BQ==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/13/2019 3:12 PM, Jon Hunter wrote:
> On 13/06/2019 10:10, Sameer Pujar wrote:
>> Add DT nodes for following devices on Tegra186 and Tegra194
>>   * ACONNECT
>>   * ADMA
>>   * AGIC
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>>   changes in current revision
>>    * use single address range for all APE modules
>>    * fix address range for agic
>>
>>   arch/arm64/boot/dts/nvidia/tegra186.dtsi | 67 ++++++++++++++++++++++++++++++++
>>   arch/arm64/boot/dts/nvidia/tegra194.dtsi | 67 ++++++++++++++++++++++++++++++++
>>   2 files changed, 134 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
>> index 426ac0b..b4d735e 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi
>> @@ -1295,4 +1295,71 @@
>>   				(GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
>>   		interrupt-parent = <&gic>;
>>   	};
>> +
>> +	aconnect@2a41000 {
> This address does not look correct. This appears to be the address of
> the AGIC. I think it should be 2900000, however, I also wonder if we
> should even bother with an address for the aconnect as this is just a
> bus and we don't specific a 'reg' property.
Do you mean, should be ok to just mention "aconnect {"?
>
>> +		compatible = "nvidia,tegra210-aconnect";
>> +		clocks = <&bpmp TEGRA186_CLK_APE>,
>> +			 <&bpmp TEGRA186_CLK_APB2APE>;
>> +		clock-names = "ape", "apb2ape";
>> +		power-domains = <&bpmp TEGRA186_POWER_DOMAIN_AUD>;
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		ranges = <0x02900000 0x0 0x02900000 0x1FFFFF>;
> This should be 0x1fffff.
done
>
>> +		status = "disabled";
>> +
>> +		dma-controller@2930000 {
>> +			compatible = "nvidia,tegra186-adma";
>> +			reg = <0x02930000 0x50000>;
>> +			interrupt-parent = <&agic>;
>> +			interrupts =  <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>,
>> +				      <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
>> +			#dma-cells = <1>;
>> +			clocks = <&bpmp TEGRA186_CLK_AHUB>;
>> +			clock-names = "d_audio";
>> +			status = "disabled";
>> +		};
>> +
>> +		agic: agic@2a41000 {
> I think that this should also be "agic: interrupt-controller@xxxx" to
> conform with standard names. Sorry the Tegra210 version is not the best
> reference!
will change
> Cheers
> Jon
>