To: linux-kernel@vger.kernel.org
From: =?iso-8859-1?Q?Bj=F8rn_Mork?= <bmork@dod.no>
Subject: Re: Resume from swsusp stopped working with 2.6.14 and 2.6.15-rc1
Date: Tue, 22 Nov 2005 09:57:43 +0100
Organization: Denizens oak Donuts
Message-ID: <871x19giuw.fsf@obelix.mork.no>
References: <87zmoa0yv5.fsf@obelix.mork.no>
	<d120d5000511181532g69107c76x56a269425056a700@mail.gmail.com>
	<20051119234850.GC1952@spitz.ucw.cz>
	<200511220026.55589.dtor_core@ameritech.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
Cancel-Lock: sha1:N2WkxaJHDblMCV+O/A+OYH7w0Ic=
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1406
Lines: 32

Dmitry Torokhov <dtor_core@ameritech.net> writes:

> Swsusp: do not time-out when stopping tasks while resuming
>
> When stopping tasks during esume process there is no point of
> eastablishing a timeout because teh process is past the point
> of no return; there is no possible recovery from failure. If
> stopping tasks fails resume is aborted and user is forced to
> do fsck anyway.

If a clueless users voice counts for anything: I couldn't agree more.  

A failed resume is a near catastrophy if you use and trust swsusp. And
how could it ever be useful if you don't?

I would much prefer a very long (indefinite) timeout, and to manually
have to force a reboot without resume.  This is an absolutely last
resort and there is no need whatsoever to automatically go there.
Maybe that even would give me a chance to fix some hardware problem
causing the timeout, and then retry the resume.

Please do everything possible to ensure that a resume will never fail
unnecessarily.  I can't see how some arbitrary timeout could be
necessary. 

Just my 2 ?re.


Bj?rn
-- 
Cardboard cut-outs are fun, huh?  So, a short man ain't got nothing in
the world these days?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/