Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190612095828.17936-1-gregkh@linuxfoundation.org>
In-Reply-To: <20190612095828.17936-1-gregkh@linuxfoundation.org>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Fri, 14 Jun 2019 01:24:46 +0900
Message-ID: <CAC5umyhSiOo6aN=cy09MdH3R3qpWiaqk+b-1Onrc_Byqc19dAQ@mail.gmail.com>
Subject: Re: [PATCH] fault-inject: clean up debugfs file creation logic
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2019=E5=B9=B46=E6=9C=8812=E6=97=A5(=E6=B0=B4) 18:58 Greg Kroah-Hartman <gre=
gkh@linuxfoundation.org>:
>
> There is no need to check the return value of a debugfs_create_file
> call, a caller should never change what they do depending on if debugfs
> is working properly or not, so remove the checks, simplifying the logic
> in the file a lot.
>
> Also fix up the error check for debugfs_create_dir() which was not
> returning NULL for an error, but rather a error pointer.
>
> Cc: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Looks good.

Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>