Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7094398ybi; Thu, 13 Jun 2019 09:26:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqz+SzozjLs5zdOy101IEOvDl5plWdoJZ69ah0lTH2WeqQnvyi6HQWSMvYL9YKx1sXpFyBD0 X-Received: by 2002:a17:902:6903:: with SMTP id j3mr13881715plk.247.1560443213653; Thu, 13 Jun 2019 09:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560443213; cv=none; d=google.com; s=arc-20160816; b=wm3XXKBxfBkVO+4R3qNzphnfhE7xULRKBO9mwvJuKqIIl+5DXM++jxRhQXvcuTjzbc Ztvrg/8HIe7OCmR+UbboQ08769ty9K3I/NchY4gbVBwla4rZtCvPo3zTeWuPIpuj40iZ T25lycC9i8FyFAJT+Dmw8PBbXU0Ty6xSCoSJJ54l58qtuqEa8OuC3ftLZXhpakLABmZG p+SjmHaOWfNk2rq5xHVtR9wI6+NMsgjDhTzYbSahXxqh2FSmflb/7ZkWesOVHosBUelb lxe/OlG8mA3PtjeX9gP0CjZn42jjr5JbqbUZk8770vp2KFNrmFQ2Jz65O7XJ2rqFcEBS KDnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=hDoQf8XVMWB4WIjEfgbzeZ3Sc8iH6yn9VUuCEmnDaKw=; b=VcoNwvVEd+GAyPGFSYbOs7xFiGDjA1/BTQoK3YkN1p2MrKbjVmpTfCBAEuQnY2Vhch 6Vu1lkFv2owfOth34uTKlGsKNeH4V+s9HuIlYxWQ77o19sjMcUxRjybLWjPNHXZYQXw3 /voBueWd1zU9VvJUd9lwvQraEnRcSvjiqeNcg8f2+CEiI89hW054cR6EbJAKldJsB12I XWdvt03EMdz+vNmKit4hut6bvSKmrg0h08i/NrPdwavBNFlg2mXiKGUvXiLxYocwKXCX Rbs+eQxCYn5S508HzbDJsVAOpWrIsj0QvWJrMkbd8DVydWwrvM6Y/3I29J12dZDnmWKl vZyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="q/iO2g/3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d37si11300plb.351.2019.06.13.09.26.38; Thu, 13 Jun 2019 09:26:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="q/iO2g/3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392012AbfFMQZA (ORCPT + 99 others); Thu, 13 Jun 2019 12:25:00 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:38720 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730984AbfFMQY6 (ORCPT ); Thu, 13 Jun 2019 12:24:58 -0400 Received: by mail-pl1-f196.google.com with SMTP id f97so8382128plb.5 for ; Thu, 13 Jun 2019 09:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hDoQf8XVMWB4WIjEfgbzeZ3Sc8iH6yn9VUuCEmnDaKw=; b=q/iO2g/3m+0dJFISoxCPlF7W5Fu4zwu37pr6P69r1zZkoab7K9d7LcVmNE+c356Ylh jQ/X2I6FlbFLefEO7W2cB0Uc5m+csgWwoZuLgvUnImrKA1cXtztX1m4ENH/e7iHKygXv pOZ+YEPAlchXUS7dW8E2lytG1MYHLHToL4avmP/yHbRRpPjhLvNubF7x5MTLYtldc80U s4+E1JgsGsjTuzr4FRoaFinD6oKCINDkJTtcEcYXyh3HfAEIpbgVF0X1fN6vXO8THeWk oQzgrjtFGbdCJw5Qc5vpannCM+5VPabA5X7BDUKksY8INYMsJxOD+acwjLlk4yGQYmK4 hM1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hDoQf8XVMWB4WIjEfgbzeZ3Sc8iH6yn9VUuCEmnDaKw=; b=cpPdLlemUauGxDrMfFCr1soxZpNqvNIj5ssPebbNBBa+i6RALQO+cgZ+6gMIYdPevf S7CO4CN+7w23rjmd9ehApXHy9edJceVeI+tbBqLLK81LaUQiU8KIiryptu9b7ZxgGon0 vj4tkOTJ+orChhzx4TMtoGY0BNbH4ZT0LHyvfE6HIjEbDxpIFUn+NbHSk7vs177NHdOQ iAPrM5gCeS+GM6vxpemx1xZs7O71TIcz1T+kIJ2MTyA3qYjl+qXA+7N14oPiNOM5C3EQ zeO5+Osd/FTKoV+oLvb9G9OU2heJBtqyUBnPW/JRoAESrLNL/RJyUyuv9+GzjgyN2hNW 1/kA== X-Gm-Message-State: APjAAAVi9+8VYCiqIC57nkz03XDdnbUK/fJ3Sijqb/mj3rtL9e0W+N9c 6cZN4wz4hg+BuvZ2u8UYax3C3wR0dlg3Lovsien3WLlx728= X-Received: by 2002:a17:902:44f:: with SMTP id 73mr30807143ple.192.1560443098024; Thu, 13 Jun 2019 09:24:58 -0700 (PDT) MIME-Version: 1.0 References: <20190612095828.17936-1-gregkh@linuxfoundation.org> In-Reply-To: <20190612095828.17936-1-gregkh@linuxfoundation.org> From: Akinobu Mita Date: Fri, 14 Jun 2019 01:24:46 +0900 Message-ID: Subject: Re: [PATCH] fault-inject: clean up debugfs file creation logic To: Greg Kroah-Hartman Cc: LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2019=E5=B9=B46=E6=9C=8812=E6=97=A5(=E6=B0=B4) 18:58 Greg Kroah-Hartman : > > There is no need to check the return value of a debugfs_create_file > call, a caller should never change what they do depending on if debugfs > is working properly or not, so remove the checks, simplifying the logic > in the file a lot. > > Also fix up the error check for debugfs_create_dir() which was not > returning NULL for an error, but rather a error pointer. > > Cc: Akinobu Mita > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Looks good. Reviewed-by: Akinobu Mita