Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7097746ybi; Thu, 13 Jun 2019 09:30:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzE3gs8ceeyG/jSC6M5dtIZ4eB5Zngl35PR1K5ScarzriSNNtW5W8LvFY8Marg9e8FIQT7 X-Received: by 2002:a63:1516:: with SMTP id v22mr32264664pgl.204.1560443433193; Thu, 13 Jun 2019 09:30:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560443433; cv=none; d=google.com; s=arc-20160816; b=LZCG1vJ/9T4Lfbw+PZlnuqda4sgjNwg+lK9Iai4a8G/XAp4aIkKm1zuzC/1b25s8Lf yCAVT1PDD9NtIHtsINWzmw72LV+NML9G/4RH6teeUWDAvcI7Gevse5l+GMEBzlrTNYte Tj48GHZUguztj+7q2Xd4Hwg1Z75ler+JlzWuMUw9LtfrFazOVtYWHYQtRYv2TvHyQ/dx seZk9sXGIinBk58j4yoWJiKJsy68ZMuNWkuMxRq248QQMUg962Aesh0htIIjeRdx0S2L kGxsENoDkINUc8AXNB3+0rkW6KOZi6RvVgm+/S14VC1wg+lptlbGGRVGDfFksrAHqAnB XbDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=pGoRdSewfCJaFQMoB+DeGbjQdzStZD8Lw2g62z7YIxY=; b=eI0/K+7N+SDXPbgoVcZ/JIxxFrH1vU9JwepA24eMQGWCmGbg77FMQSYLgcGhsA/05E F2MdqTcU60FS3ia0WtzYWZEdKwPQZ0jt0B0gFx6icVixylHMyxlL3EszKrdQ8ikuIr8w l+3bRkuvofOWzon2HAEfMEFleutiYOf08tHvyvgMbFIPqbC5QZIaMGiaFbBwGu0zzzy0 EuvhdC/3gzGo8Z11mDG+IVuKiGZ0p7HEukhL1C6yAMr5CSM/NbR2Ko5v5NAImhhm8ofV TH3/jnimGtC0dbmkhZ8yCHBbCwkVwiw4TW5eh1fYtAr3wnHJ9S4RuSqmGfkUnLI6uhSf iLSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c1si2253pld.418.2019.06.13.09.30.17; Thu, 13 Jun 2019 09:30:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392521AbfFMQ3g (ORCPT + 99 others); Thu, 13 Jun 2019 12:29:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392508AbfFMQ3a (ORCPT ); Thu, 13 Jun 2019 12:29:30 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0F151C01F28C; Thu, 13 Jun 2019 16:29:30 +0000 (UTC) Received: from flask (unknown [10.40.205.10]) by smtp.corp.redhat.com (Postfix) with SMTP id 23A5F5ED3C; Thu, 13 Jun 2019 16:29:26 +0000 (UTC) Received: by flask (sSMTP sendmail emulation); Thu, 13 Jun 2019 18:29:26 +0200 Date: Thu, 13 Jun 2019 18:29:26 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini Subject: Re: [PATCH] KVM: nVMX: use correct clean fields when copying from eVMCS Message-ID: <20190613162926.GA24797@flask> References: <20190613113502.9535-1-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190613113502.9535-1-vkuznets@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 13 Jun 2019 16:29:30 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2019-06-13 13:35+0200, Vitaly Kuznetsov: > Unfortunately, a couple of mistakes were made while implementing > Enlightened VMCS support, in particular, wrong clean fields were > used in copy_enlightened_to_vmcs12(): > - exception_bitmap is covered by CONTROL_EXCPN; > - vm_exit_controls/pin_based_vm_exec_control/secondary_vm_exec_control > are covered by CONTROL_GRP1. > > Fixes: 945679e301ea0 ("KVM: nVMX: add enlightened VMCS state") > Signed-off-by: Vitaly Kuznetsov > --- Reviewed-by: Radim Krčmář