Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp7099646ybi; Thu, 13 Jun 2019 09:32:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqNLoZotmKrJCKjvrfLmMzxCMzMaacfrPft/8d0xESJ/wQIo80gljBRpfPApVAU/1liq7P X-Received: by 2002:a17:902:b691:: with SMTP id c17mr66108690pls.107.1560443542272; Thu, 13 Jun 2019 09:32:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560443542; cv=none; d=google.com; s=arc-20160816; b=u5u42+sJBNHfSGpajIcrR5KQOO4MXKR5p5RgAZsVr5pdn2wWOeLLZXf+PWY6LPsd4w kb6BqxKBLiilx3SCdvbqC3Eee7R8sq4uJyBdQuHsBr63s6UQUbspASt/hR62YXuvbIUm pX5T02AG32WKHqrNeLlBpnSjr7JOxz0KWvztSr5LUk/Rh/fu0EVP7OKzFB0+ajpcUguX okjA8HR1XzQJopgHMC2f+/gx73sg8TQFzoGvbqQpe5dKyQBBcR62eW3ZsaCCrQ4mMQoH 2gjgqQjZr5V3rCsbLrNu2MPdZ6v6NGmn6f62jPwz3IK/NqlV0Og+7HYEp4YNpTgJ+sKT aOLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=qShYouWOrO2P4M1ZBJfQCzwSFQ7+BKHcrZX/LY1rQuc=; b=npom2YTAEqxHa73wlv6cQa8+XXbpsbcZPziQyDclyqFvBrnRtcpOiWcng8Oi7ZnGUP WBZ3F1ttUoK4egWChLxHtXfu0hY3IykZ5N01T/uMtaW1gMsODWqja2u62J7kB5jWDP2L l2w/cWNg5x5JCrs6VPxuTuJUhtBAvwb0/baMYsY+jvthEnW6/6NHoxdtxllUnwbkX0Wv TCe/C9tHa6lwfZTTF3mhxwg00kAyhWQPakCaxeeYY6Agcij2em8smx6uW+63ociUESpt lKxdTQQpEmhEyHIf59V6rDJiG/Ylz8xDVtQZwFAZwzipBjZ4buEXVjwzcdvnqIeEGVB1 cWdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g8si104228pgd.64.2019.06.13.09.32.07; Thu, 13 Jun 2019 09:32:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731840AbfFMQbr (ORCPT + 99 others); Thu, 13 Jun 2019 12:31:47 -0400 Received: from mx2.suse.de ([195.135.220.15]:44832 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730868AbfFMIXU (ORCPT ); Thu, 13 Jun 2019 04:23:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E4C40AD5E; Thu, 13 Jun 2019 08:23:18 +0000 (UTC) Date: Thu, 13 Jun 2019 10:23:18 +0200 From: Michal Hocko To: Joel Savitz Cc: linux-kernel@vger.kernel.org, Rafael Aquini , Andrew Morton , David Rientjes , linux-mm@kvack.org Subject: Re: [RESEND PATCH v2] mm/oom_killer: Add task UID to info message on an oom kill Message-ID: <20190613082318.GB9343@dhcp22.suse.cz> References: <1560362273-534-1-git-send-email-jsavitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1560362273-534-1-git-send-email-jsavitz@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 12-06-19 13:57:53, Joel Savitz wrote: > In the event of an oom kill, useful information about the killed > process is printed to dmesg. Users, especially system administrators, > will find it useful to immediately see the UID of the process. Could you be more specific please? We already print uid when dumping eligible tasks so it is not overly hard to find that information in the oom report. Well, except when dumping of eligible tasks is disabled. Is this what you are after? Please always be specific about usecases in the changelog. A terse statement that something is useful doesn't tell much very often. Thanks! -- Michal Hocko SUSE Labs