Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net v2] tcp: avoid creating multiple req socks with the
 same tuples
To:     David Miller <davem@davemloft.net>
References: <20190612035715.166676-1-maowenan@huawei.com>
 <20190612.092507.915453305221203158.davem@davemloft.net>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <edumazet@google.com>
From:   maowenan <maowenan@huawei.com>
Message-ID: <2d3d6b84-acaa-b98a-8454-96546fbe012d@huawei.com>
Date:   Thu, 13 Jun 2019 14:34:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20190612.092507.915453305221203158.davem@davemloft.net>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/6/13 0:25, David Miller wrote:
> From: Mao Wenan <maowenan@huawei.com>
> Date: Wed, 12 Jun 2019 11:57:15 +0800
> 
>> diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c
>> index c4503073248b..b6a1b5334565 100644
>> --- a/net/ipv4/inet_hashtables.c
>> +++ b/net/ipv4/inet_hashtables.c
>> @@ -477,6 +477,7 @@ bool inet_ehash_insert(struct sock *sk, struct sock *osk)
>>  	struct inet_ehash_bucket *head;
>>  	spinlock_t *lock;
>>  	bool ret = true;
>> +	struct sock *reqsk = NULL;
> 
> Please preserve the reverse christmas tree local variable ordering here.

ok, thanks.
> 
> Thank you.
> 
> .
>