Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp59898ybi; Thu, 13 Jun 2019 11:36:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqyEGEDDyy/0+qCfpPfysdfDPn7dDa0aiQC5HbLTpt8ucG3XMcY8kzUgKHKm8w54MS4IoDVm X-Received: by 2002:a63:610d:: with SMTP id v13mr31449536pgb.341.1560450973602; Thu, 13 Jun 2019 11:36:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560450973; cv=none; d=google.com; s=arc-20160816; b=C7kC/CRQKkGq5jfZOHEtDWEja0byFYEKNuUe2UZX2rI7so5lqv8DDEwZkP78kx9bw7 jUH5i+HQNxtdFCtG+7cS06I02+3A3Of5yIrG3cyu2l0njYLDsK5x45CFrvZ6kX/bs1tO hwAZa14keILvi0DiKNgMk68OhxQY5h3HrmAmZ2zSvHdhLWaRzWtD7yykozCXVeyyjPp5 FV6tc2UifgaxUHs34R7L1NmRSdYqvUuhhDo+pKLX61YVbMSou/SMD23DezXcwDWnJmxf M8eABycrLejeZmQtD1g4+WL35OuGCreCt820EbGAln9kJuMBOyznhoXL3u2qKm4lbPyX rAGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=WswWD2tTfDP/fIDGklIQa40y3v3VUYwuv6L/jsoQ6uQ=; b=BarryOm7Vov7rwkCc5x+OXh/AQMnGALbi7oqGI3Ex7oMwIJGj3hAGPpHmU6uWFWJIF U/cFnpVpI/0GidJ4k6Z7KOQWBWODG4ROC8u1SmtsmOLNZ+84MJcMUZ+VGmL7tWFtIpMZ R4ZkeLkod4UVMQRqPWw+6EsOWc0xUUMskqqfed9U1xchrqdeUEDptmPV8678SEYhigm4 Xriy6iRrdl9ZDX/L2FyE6qp/97iKhoRQq/Z8Hpno4+K4jkej85Rmj8p5DS/rdrhP392F bf9nKBWx7ojiLgnul7+isAy69i0tN1YmL4XJXd2VHHGzgeRBQ11cafJL7VXtneJwSMfc ydUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m20si340060pjn.9.2019.06.13.11.35.58; Thu, 13 Jun 2019 11:36:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbfFMSeL (ORCPT + 99 others); Thu, 13 Jun 2019 14:34:11 -0400 Received: from mga09.intel.com ([134.134.136.24]:21227 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727378AbfFMSeJ (ORCPT ); Thu, 13 Jun 2019 14:34:09 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 11:34:08 -0700 X-ExtLoop1: 1 Received: from lahna.fi.intel.com (HELO lahna) ([10.237.72.157]) by fmsmga001.fm.intel.com with SMTP; 13 Jun 2019 11:34:05 -0700 Received: by lahna (sSMTP sendmail emulation); Thu, 13 Jun 2019 21:34:05 +0300 Date: Thu, 13 Jun 2019 21:34:05 +0300 From: Mika Westerberg To: Stefan Roese Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Yegor Yefremov , Andy Shevchenko , Giulio Benetti , Greg Kroah-Hartman Subject: Re: [PATCH 3/3 v6] tty/serial/8250: use mctrl_gpio helpers Message-ID: <20190613183405.GT2640@lahna.fi.intel.com> References: <20190613154542.32438-1-sr@denx.de> <20190613154542.32438-3-sr@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190613154542.32438-3-sr@denx.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 05:45:42PM +0200, Stefan Roese wrote: > From: Yegor Yefremov > > This patch permits the usage for GPIOs to control > the CTS/RTS/DTR/DSR/DCD/RI signals. > > Changed by Stefan: > Only call mctrl_gpio_init(), if the device has no ACPI companion device > to not break existing ACPI based systems. Also only use the mctrl_gpio_ > functions when "gpios" is available. > > Use MSR / MCR <-> TIOCM wrapper functions. > > Signed-off-by: Yegor Yefremov > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Stefan Roese > Cc: Mika Westerberg Reviewed-by: Mika Westerberg