Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To:     "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>
CC:     "sr@denx.de" <sr@denx.de>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: cfi_cmdset_0002: dynamically determine the max
 sectors
Thread-Topic: [PATCH] mtd: cfi_cmdset_0002: dynamically determine the max
 sectors
Thread-Index: AQHVEDI+CoqUJR97jEy7wwMr7iI19Q==
Date:   Fri, 14 Jun 2019 03:23:57 +0000
Message-ID: <8e80d911f0dd4759b3edc72fb76530d6@svr-chch-ex1.atlnz.lc>
References: <20190522000628.13073-1-chris.packham@alliedtelesis.co.nz>
Accept-Language: en-NZ, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi All,=0A=
=0A=
I think this may have got lost in the change of maintainer for mtd.=0A=
=0A=
On 22/05/19 12:06 PM, Chris Packham wrote:=0A=
> Because PPB unlocking unlocks the whole chip cfi_ppb_unlock() needs to=0A=
> remember the locked status for each sector so it can re-lock the=0A=
> unaddressed sectors. Dynamically calculate the maximum number of sectors=
=0A=
> rather than using a hardcoded value that is too small for larger chips.=
=0A=
> =0A=
> Tested with Spansion S29GL01GS11TFI flash device.=0A=
> =0A=
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>=0A=
> ---=0A=
>   drivers/mtd/chips/cfi_cmdset_0002.c | 13 ++++++++-----=0A=
>   1 file changed, 8 insertions(+), 5 deletions(-)=0A=
> =0A=
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_=
cmdset_0002.c=0A=
> index c8fa5906bdf9..a1a7d334aa82 100644=0A=
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c=0A=
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c=0A=
> @@ -2533,8 +2533,6 @@ struct ppb_lock {=0A=
>   	int locked;=0A=
>   };=0A=
>   =0A=
> -#define MAX_SECTORS			512=0A=
> -=0A=
>   #define DO_XXLOCK_ONEBLOCK_LOCK		((void *)1)=0A=
>   #define DO_XXLOCK_ONEBLOCK_UNLOCK	((void *)2)=0A=
>   #define DO_XXLOCK_ONEBLOCK_GETLOCK	((void *)3)=0A=
> @@ -2633,6 +2631,7 @@ static int __maybe_unused cfi_ppb_unlock(struct mtd=
_info *mtd, loff_t ofs,=0A=
>   	int i;=0A=
>   	int sectors;=0A=
>   	int ret;=0A=
> +	int max_sectors;=0A=
>   =0A=
>   	/*=0A=
>   	 * PPB unlocking always unlocks all sectors of the flash chip.=0A=
> @@ -2640,7 +2639,11 @@ static int __maybe_unused cfi_ppb_unlock(struct mt=
d_info *mtd, loff_t ofs,=0A=
>   	 * first check the locking status of all sectors and save=0A=
>   	 * it for future use.=0A=
>   	 */=0A=
> -	sect =3D kcalloc(MAX_SECTORS, sizeof(struct ppb_lock), GFP_KERNEL);=0A=
> +	max_sectors =3D 0;=0A=
> +	for (i =3D 0; i < mtd->numeraseregions; i++)=0A=
> +		max_sectors +=3D regions[i].numblocks;=0A=
> +=0A=
> +	sect =3D kcalloc(max_sectors, sizeof(struct ppb_lock), GFP_KERNEL);=0A=
>   	if (!sect)=0A=
>   		return -ENOMEM;=0A=
>   =0A=
> @@ -2689,9 +2692,9 @@ static int __maybe_unused cfi_ppb_unlock(struct mtd=
_info *mtd, loff_t ofs,=0A=
>   		}=0A=
>   =0A=
>   		sectors++;=0A=
> -		if (sectors >=3D MAX_SECTORS) {=0A=
> +		if (sectors >=3D max_sectors) {=0A=
>   			printk(KERN_ERR "Only %d sectors for PPB locking supported!\n",=0A=
> -			       MAX_SECTORS);=0A=
> +			       max_sectors);=0A=
>   			kfree(sect);=0A=
>   			return -EINVAL;=0A=
>   		}=0A=
> =0A=
=0A=