Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp574422ybi; Thu, 13 Jun 2019 23:07:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqwKS0oU/EymQb9Xy40ONo1hyAi8BfZpbU0XBBQJp3zWnajLlKrVcb1Doy8qoUf4VTf+++Uf X-Received: by 2002:a17:902:2889:: with SMTP id f9mr43588692plb.230.1560492456334; Thu, 13 Jun 2019 23:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560492456; cv=none; d=google.com; s=arc-20160816; b=twInPImR1LL/5bACBn3r3V/I4EyCnks5hKnmQ8ozUwDA8f5jmJnDxWiHXPG0wNOtzt G1oLe+cQ9SdJozaL63TNInbWoS2DLnTfYzeGO+FGaHdPsOutmuR8m0KC5JeS1+V+HfzE vEqP+PFys/E4vdgz05JiwujO1njG9zro6F1OzQr51BKMqYp4XLramDKD/EULPzmKMSVK S716b9GBRCiK87d8XHRleMk9bjOga0Mgn++zp1Du45JOfnl6h8zdk5/x1/rD/j8FmeIs 3VPQbOszDEOle74I/ja/fVJ3mbMlwfeGxMV/ovrFBAYUW9QuBeJSAk2VqUA6IadtPddV dIxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vFqoZrLn4XJruK+9pn7RAj8QC3xVsIBz0Ldc8KI1RK4=; b=T0ujO8sW/V41b/wd2XhbVjeUpyhIlLfwL/5y5nT/uZneTxB3siavq/1zzsQBtlux4t DxtjkhPAiaKZmgE+NuO4/6MpnGfk4WuBZzjbTzoTjBw+caFbNDTsUAZ5YX0z2qH2nbjv +OHC3TqBAxgD4MleulqBdp1Tk265JyjZpVQkmpyMKvLLdevHHUI4wzCat0U93BpMvu2b IXPVRU9gnmM2O592bEmv2UeYdmB6fmBOCL0VYuYFDAd1kODraSVMFtLshO+3H3QgB5YO lDVpaONtz23u2w/JephALgCaYfYJNkk9n4cwu6L6i4Fft+L+3/ADj5J7J9cLsjz4je2k Jw7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=jYF2DJel; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g2si1556354pgs.215.2019.06.13.23.07.13; Thu, 13 Jun 2019 23:07:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=jYF2DJel; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbfFNGGZ (ORCPT + 99 others); Fri, 14 Jun 2019 02:06:25 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:40964 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfFNGGZ (ORCPT ); Fri, 14 Jun 2019 02:06:25 -0400 Received: by mail-ot1-f67.google.com with SMTP id 107so1560714otj.8 for ; Thu, 13 Jun 2019 23:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vFqoZrLn4XJruK+9pn7RAj8QC3xVsIBz0Ldc8KI1RK4=; b=jYF2DJelMMrI8nnlZYsIYlnmUV+N30iTkEsMcMyr3v70I6bMnL2jhLm84BQPGlUu7C IEj3zolvKRIWNvp2+qJ81sOfAsIZPdiuIjo3RX3HPF0WQfMepylltFEkfnr7J0orOj2H ZEjpZfdUD+sOVeygs/KETF5r8o9PEw4lLkGZrv0ycL7J0S86+fWyok/T+lLeY+db8FbX DdzoNMvJgRIYgmuLu+EgEPXmtonsNifm8/O5IyxWPCo+Ju2HxUEVC0vlLiDskCzJlKTq hVGYveUBp/H4sOoj6DLcivr880qKBE8yqn3sfiwDStAlf257cT+FK3s37Neer/T3IjEc uo0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vFqoZrLn4XJruK+9pn7RAj8QC3xVsIBz0Ldc8KI1RK4=; b=bydxTKfiwoQHY7dCzcMHtywvH75eRGiwqN7Uq3UFeb9/fZFuBRUyVF/1LuD1ZKLR3M 07PbPi614Tqhl9aHv3j2AWNcOOZ0OThFGWnpIr+ydfiaYSON4Gtek4adG6MP3kF0N1U6 YZFh3jkLVYulbnob/9gixw8kbxJ7imjEeKTvUVsWD7oNRZapppp3l2LeWgpujSCtB2Z5 +EXpV2576UVB/AOdvBA5936INbg72LqlGtMFg8QHE7H+y43R+DKFGUyNPHCodCQvlnMH mK2EVhhd8kODlmf5XbCeO+9r1RTSsSyqE0GQxrEXmEMIw9XiCrY0GOburQ/iQRd3AxRj gusQ== X-Gm-Message-State: APjAAAWnQRdT8wq2WyhCAT0BMEFgz9jQY2AerAGi+hXBlnhtzXX71/NV FzJ8lxB4GcEhq7AtcndmWBsrVaOz6a+IHg7db45ooA== X-Received: by 2002:a9d:7248:: with SMTP id a8mr3089404otk.363.1560492384101; Thu, 13 Jun 2019 23:06:24 -0700 (PDT) MIME-Version: 1.0 References: <20190614060143.17867-1-richardw.yang@linux.intel.com> In-Reply-To: <20190614060143.17867-1-richardw.yang@linux.intel.com> From: Dan Williams Date: Thu, 13 Jun 2019 23:06:13 -0700 Message-ID: Subject: Re: [PATCH] kernel/memremap.c: use ALIGN/ALIGN_DOWN to calculate align_start/end To: Wei Yang Cc: Linux Kernel Mailing List , Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Dave Jiang , Oscar Salvador , Michal Hocko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 11:02 PM Wei Yang wrote: > > The purpose of align_start/end is to expand to SECTION boundary. Use > ALIGN/ALIGN_DOWN directly is more self-explain and clean. I'm actively trying to kill this code [1] so I don't see the need for this patch. [1]: https://lore.kernel.org/lkml/155977193326.2443951.14201009973429527491.stgit@dwillia2-desk3.amr.corp.intel.com/