Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Jun 2019 08:09:19 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc:     groeck@google.com, linux-kernel@vger.kernel.org,
        groeck@chromium.org, adurbin@chromium.org, dlaurie@chromium.org
Subject: Re: [PATCH] gsmi: replace printk with relevant dev_<level>
Message-ID: <20190614060919.GA7271@kroah.com>
References: <20190613185705.GA16951@ahmlpt0706>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190613185705.GA16951@ahmlpt0706>
User-Agent: Mutt/1.12.0 (2019-05-25)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 14, 2019 at 12:27:05AM +0530, Saiyam Doshi wrote:
> Replace printk() with dev_* macros for logging consistency.
> In process of replacing printk with dev_err, dev_info etc.,
> removed unnecessary "out of memory" debug message.

That is multiple things done in the same patch, please break this up
into a patch series, only doing one "logical" thing per patch.

Note, generic cleanup patches like this are tough to get done in the
"real" part of the kernel, I strongly recommend you start out in
drivers/staging/ where these types of changes are welcomed.  Get
experience there and then move out into other areas of the kernel if you
want to, that way you don't annoy developers/maintainers with basic
errors like this.

good luck!

greg k-h