Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp594656ybi; Thu, 13 Jun 2019 23:34:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzsOBXtMvFWne9/uIqwCAQB96oGEEbDZW2SVXaylngDCL6yy79cz2bXKZT7zcMqgzYRNgjw X-Received: by 2002:a63:ed13:: with SMTP id d19mr26985755pgi.100.1560494076968; Thu, 13 Jun 2019 23:34:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560494076; cv=none; d=google.com; s=arc-20160816; b=js3qCjN0G8d2rJ+zk6Xa9YJou8z15jiS4NVvTLSpjLbHMGNtSWunKlv0b/nl5cMPV1 DqXPqNJTA7HPvcCRb9XKrmmHbc8nb8ujKq/BiCN6w0b0c5PXx49R6iFkUmxwJmpVO5k2 GKA7DWw84RC4EdMl29bnMBHUVFMM1YeDsIT7keHSqsRs5Ye6DrVu8fYRlzXZ/O97x4RJ M47Q8bpI7hmNYWsAq2Abm4FBvcw8yXMyqOLC5cnWueFP4dGVU94uuHWo6aVnNhTtmuLb xArEd0LBHDUgXS0NTwC0XYV96SpyJEGAxQ0CYDmquX+7hovDlrEuKUb2taNAo8SEw9+d Lvhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=8PO9Ydpr/GVVUxr4C+H3kt9HIjXw2MJwYNSsRclH1s4=; b=JE4SHjO4OVJ7U7tr6DjSXaUN7+ia5O2lLa2w+JuPXcMRGaJ6dNGFnrZ1Tca4xl52Fo GrabMGnZoNN+u4ZDFFT4e6b9WX+fEhL3BNDhaDYEOJt5gWwadXWkDtb62iMk/YnW7RSL 6+T+nuP/MFS6y43Ytud1rgqjsX2FzT+ATWl6HKbYccDgPvrXeT9Ov8msfYZhlJLuHWcq hWHHlyTMU7mw8OhfcLcY0X2IbaEtLAqN8ggxzfvxX7ULin4PgxvJ6Tq6di413GX8myB7 6Hqw7qMKztJouPwMkEH30nhtoGOpLG11a9Y8wonyXU1Of+rXq6M/bd3QhdU32/txOtkX kpRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j1si1519915pfr.52.2019.06.13.23.34.19; Thu, 13 Jun 2019 23:34:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725973AbfFNGdr (ORCPT + 99 others); Fri, 14 Jun 2019 02:33:47 -0400 Received: from verein.lst.de ([213.95.11.211]:44432 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFNGdr (ORCPT ); Fri, 14 Jun 2019 02:33:47 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id DDC1568B02; Fri, 14 Jun 2019 08:33:17 +0200 (CEST) Date: Fri, 14 Jun 2019 08:33:17 +0200 From: Christoph Hellwig To: Ralph Campbell Cc: Christoph Hellwig , Dan Williams , =?iso-8859-1?B?Suly9G1l?= Glisse , Jason Gunthorpe , Ben Skeggs , linux-mm@kvack.org, nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-nvdimm@lists.01.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/22] memremap: add a migrate callback to struct dev_pagemap_ops Message-ID: <20190614063317.GJ7246@lst.de> References: <20190613094326.24093-1-hch@lst.de> <20190613094326.24093-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 13, 2019 at 04:42:07PM -0700, Ralph Campbell wrote: > This needs to either initialize "page" or be changed to "vmf->page". > Otherwise, it is a NULL pointer dereference. Thanks, fixed.