Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp657170ybi;
        Fri, 14 Jun 2019 00:55:36 -0700 (PDT)
X-Google-Smtp-Source: APXvYqwESNeEfQEVZ078FlKlkZfYPfZnsvsAimZZ2riubW+LZ7Fyy6XWHQlQjoYilGoMf2UqIaSE
X-Received: by 2002:a62:ed1a:: with SMTP id u26mr71619801pfh.229.1560498936020;
        Fri, 14 Jun 2019 00:55:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1560498936; cv=none;
        d=google.com; s=arc-20160816;
        b=eAp4vUomJVQuSYjvmfffiHTvjTa75kr4qXP4g0llAGR3hXu8sYyz7GJlOMBZzD3CoP
         Yz7NTYRCAkw4fPdyMlw4yUudQRAHDvvw+qY7bFnN79zXlUn29P4qkIL8N0PoF23ZexKQ
         6Jz1z8L0nTETXp2TJMA0cjyCMFcBqQZClLq/syH41LC5tAg3FGS0Vt6iN9Rks1+mF/r6
         xUiHapo2y+264g/e8SjiAnR/2GJTD13nvDn0fGp839K50seHqOzPQM5Q/Um6GS9Fy0Rk
         9uFtSKyIZE9CMTBTHta6xuBoNTD0TudCHxdLx7pCjr8pPIZMLt5PH16lY9IuINufh4zK
         glbg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=PvLi/3uJKuqXnNjSGw++iphQUNXLUGBA4QDUp5FLBLs=;
        b=uTbrv2TWE/Z6i80MicW91BCTrr/Us/ET4t1aM/LexpByYmzehwhKsidAj6zC3mobGx
         JCEv9HJSQl/SsybbdwVXLazw3V3HVN+TCGmaKqTURRdWG28LQkQfyDcK+c1CubdVG9Oy
         TO5IxVYv1DDO9p8zHTu87gEFjKZRJKX8F64yPI058PeBWEZTVee454Scm8OR95DWc5mf
         OBm9l4GjUxzfdP48WCgL2GtMih9nGQ4ZzFxCuvSsmfTpC37FIbyX+AZPBIpSoFB4bDoj
         YnNdZ3HPLkGwe7Foaty9vPCOfoqUbfJlDGGDxDRfgOHN34v2wCejlA2mIT4SwrkZiWB5
         dhzw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=JpY++WnU;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id h5si1534788plt.232.2019.06.14.00.55.20;
        Fri, 14 Jun 2019 00:55:36 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=JpY++WnU;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725973AbfFNHyj (ORCPT <rfc822;0330sisy@gmail.com> + 99 others);
        Fri, 14 Jun 2019 03:54:39 -0400
Received: from mail.kernel.org ([198.145.29.99]:57086 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725823AbfFNHyj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 14 Jun 2019 03:54:39 -0400
Received: from linux-8ccs (unknown [92.117.145.174])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 5719B2133D;
        Fri, 14 Jun 2019 07:54:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1560498878;
        bh=PvLi/3uJKuqXnNjSGw++iphQUNXLUGBA4QDUp5FLBLs=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=JpY++WnUzAw3IJDTvRBUKK2iIPX3b97pKYzjW9Ei2V0Cavtbn7tXHUm5i72OZxKbp
         aaW6RaewocjHEJyMnB+01m6sLhNFazPaVvsTBPZmFn92HVG5g5c4ym8eLd9o1+FIP1
         Uzr7ERt11Q9jS8IIFNsTFIcil5R60M9fJixk+lr4=
Date:   Fri, 14 Jun 2019 09:54:33 +0200
From:   Jessica Yu <jeyu@kernel.org>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     gregkh@linuxfoundation.org, mbenes@suse.cz,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] kernel/module: Fix mem leak in
 module_add_modinfo_attrs
Message-ID: <20190614075433.GA5820@linux-8ccs>
References: <20190603144554.18168-1-yuehaibing@huawei.com>
 <20190611150007.21064-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20190611150007.21064-1-yuehaibing@huawei.com>
X-OS:   Linux linux-8ccs 5.1.0-rc1-lp150.12.28-default+ x86_64
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+++ YueHaibing [11/06/19 23:00 +0800]:
>In module_add_modinfo_attrs if sysfs_create_file
>fails, we forget to free allocated modinfo_attrs
>and roll back the sysfs files.
>
>Fixes: 03e88ae1b13d ("[PATCH] fix module sysfs files reference counting")
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied, thanks.

Jessica